* [PATCH 02/15] video: ep93xx: remove unnecessary platform_set_drvdata()
@ 2013-05-11 12:47 Jingoo Han
2013-05-14 0:47 ` H Hartley Sweeten
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-11 12:47 UTC (permalink / raw)
To: linux-fbdev
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/ep93xx-fb.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c
index ee1ee54..28a837d 100644
--- a/drivers/video/ep93xx-fb.c
+++ b/drivers/video/ep93xx-fb.c
@@ -595,7 +595,6 @@ failed_videomem:
fb_dealloc_cmap(&info->cmap);
failed_cmap:
kfree(info);
- platform_set_drvdata(pdev, NULL);
return err;
}
@@ -614,7 +613,6 @@ static int ep93xxfb_remove(struct platform_device *pdev)
fbi->mach_info->teardown(pdev);
kfree(info);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 02/15] video: ep93xx: remove unnecessary platform_set_drvdata()
2013-05-11 12:47 [PATCH 02/15] video: ep93xx: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-14 0:47 ` H Hartley Sweeten
0 siblings, 0 replies; 2+ messages in thread
From: H Hartley Sweeten @ 2013-05-14 0:47 UTC (permalink / raw)
To: linux-fbdev
On Saturday, May 11, 2013 5:47 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/ep93xx-fb.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-14 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 12:47 [PATCH 02/15] video: ep93xx: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-14 0:47 ` H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).