From: Jingoo Han <jg1.han@samsung.com>
To: 'Andrew Morton' <akpm@linux-foundation.org>
Cc: 'Shuah Khan' <shuah.kh@samsung.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shuahkhan@gmail.com, rpurdie@rpsys.net, FlorianSchandinat@gmx.de,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
rafael.j.wysocki@intel.com, 'Arnd Bergmann' <arnd@arndb.de>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: [PATCH] backlight: add CONFIG_PM_SLEEP to suspend/resume functions
Date: Fri, 07 Jun 2013 01:39:20 +0000 [thread overview]
Message-ID: <000201ce631f$d4ad0d50$7e0727f0$@samsung.com> (raw)
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when
the CONFIG_PM_SLEEP is enabled.
drivers/video/backlight/backlight.c:211:12: warning: 'backlight_suspend' defined but not used [-Wunused-function]
drivers/video/backlight/backlight.c:225:12: warning: 'backlight_resume' defined but not used [-Wunused-function]
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/backlight.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index cedbcbe..750807c 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -208,6 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev,
static struct class *backlight_class;
+#ifdef CONFIG_PM_SLEEP
static int backlight_suspend(struct device *dev)
{
struct backlight_device *bd = to_backlight_device(dev);
@@ -235,6 +236,7 @@ static int backlight_resume(struct device *dev)
return 0;
}
+#endif
static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend,
backlight_resume);
--
1.7.10.4
next reply other threads:[~2013-06-07 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 1:39 Jingoo Han [this message]
2013-06-07 10:02 ` [PATCH] backlight: add CONFIG_PM_SLEEP to suspend/resume functions Arnd Bergmann
2013-06-10 23:31 ` Andrew Morton
2013-06-12 12:08 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-07 10:22 ` Arnd Bergmann
2013-06-10 15:34 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201ce631f$d4ad0d50$7e0727f0$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rpurdie@rpsys.net \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).