* [PATCH 0/2] video: s3c-fb: Adjustments for s3c_fb_probe()
@ 2017-11-26 14:15 SF Markus Elfring
2017-11-26 14:16 ` [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe() SF Markus Elfring
2017-11-26 14:17 ` [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() SF Markus Elfring
0 siblings, 2 replies; 7+ messages in thread
From: SF Markus Elfring @ 2017-11-26 14:15 UTC (permalink / raw)
To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz, Jingoo Han
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 26 Nov 2017 15:12:34 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/video/fbdev/s3c-fb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.15.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe()
2017-11-26 14:15 [PATCH 0/2] video: s3c-fb: Adjustments for s3c_fb_probe() SF Markus Elfring
@ 2017-11-26 14:16 ` SF Markus Elfring
2017-11-27 18:06 ` [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob Jingoo Han
2017-11-26 14:17 ` [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() SF Markus Elfring
1 sibling, 1 reply; 7+ messages in thread
From: SF Markus Elfring @ 2017-11-26 14:16 UTC (permalink / raw)
To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz, Jingoo Han
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 26 Nov 2017 15:00:16 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/video/fbdev/s3c-fb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 5f4f696c2ecf..0914c973cbd9 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1384,10 +1384,8 @@ static int s3c_fb_probe(struct platform_device *pdev)
}
sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL);
- if (!sfb) {
- dev_err(dev, "no memory for framebuffers\n");
+ if (!sfb)
return -ENOMEM;
- }
dev_dbg(dev, "allocate new framebuffer %p\n", sfb);
--
2.15.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob
2017-11-26 14:16 ` [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe() SF Markus Elfring
@ 2017-11-27 18:06 ` Jingoo Han
2018-03-28 14:02 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 7+ messages in thread
From: Jingoo Han @ 2017-11-27 18:06 UTC (permalink / raw)
To: 'SF Markus Elfring', linux-fbdev, dri-devel,
'Bartlomiej Zolnierkiewicz'
Cc: kernel-janitors, 'LKML'
On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 26 Nov 2017 15:00:16 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
> drivers/video/fbdev/s3c-fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 5f4f696c2ecf..0914c973cbd9 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1384,10 +1384,8 @@ static int s3c_fb_probe(struct platform_device
> *pdev)
> }
>
> sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL);
> - if (!sfb) {
> - dev_err(dev, "no memory for framebuffers\n");
> + if (!sfb)
> return -ENOMEM;
> - }
>
> dev_dbg(dev, "allocate new framebuffer %p\n", sfb);
>
> --
> 2.15.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob
2017-11-27 18:06 ` [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob Jingoo Han
@ 2018-03-28 14:02 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 7+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-03-28 14:02 UTC (permalink / raw)
To: Jingoo Han, 'SF Markus Elfring'
Cc: linux-fbdev, kernel-janitors, 'LKML', dri-devel
On Monday, November 27, 2017 01:06:30 PM Jingoo Han wrote:
> On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote:
> >
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 26 Nov 2017 15:00:16 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
Patch queued for 4.17, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe()
2017-11-26 14:15 [PATCH 0/2] video: s3c-fb: Adjustments for s3c_fb_probe() SF Markus Elfring
2017-11-26 14:16 ` [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe() SF Markus Elfring
@ 2017-11-26 14:17 ` SF Markus Elfring
2017-11-27 18:07 ` Jingoo Han
1 sibling, 1 reply; 7+ messages in thread
From: SF Markus Elfring @ 2017-11-26 14:17 UTC (permalink / raw)
To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz, Jingoo Han
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 26 Nov 2017 15:03:03 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/video/fbdev/s3c-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 0914c973cbd9..8c7623d63eb1 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1383,7 +1383,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
return -EINVAL;
}
- sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL);
+ sfb = devm_kzalloc(dev, sizeof(*sfb), GFP_KERNEL);
if (!sfb)
return -ENOMEM;
--
2.15.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe()
2017-11-26 14:17 ` [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() SF Markus Elfring
@ 2017-11-27 18:07 ` Jingoo Han
2018-03-28 14:05 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 7+ messages in thread
From: Jingoo Han @ 2017-11-27 18:07 UTC (permalink / raw)
To: 'SF Markus Elfring', linux-fbdev, dri-devel,
'Bartlomiej Zolnierkiewicz'
Cc: kernel-janitors, 'LKML'
On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 26 Nov 2017 15:03:03 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
> drivers/video/fbdev/s3c-fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 0914c973cbd9..8c7623d63eb1 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1383,7 +1383,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL);
> + sfb = devm_kzalloc(dev, sizeof(*sfb), GFP_KERNEL);
> if (!sfb)
> return -ENOMEM;
>
> --
> 2.15.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe()
2017-11-27 18:07 ` Jingoo Han
@ 2018-03-28 14:05 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 7+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-03-28 14:05 UTC (permalink / raw)
To: Jingoo Han, 'SF Markus Elfring'
Cc: linux-fbdev, kernel-janitors, 'LKML', dri-devel
On Monday, November 27, 2017 01:07:15 PM Jingoo Han wrote:
> On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote:
> >
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sun, 26 Nov 2017 15:03:03 +0100
> >
> > Replace the specification of a data structure by a pointer dereference
> > as the parameter for the operator "sizeof" to make the corresponding size
> > determination a bit safer according to the Linux coding style convention.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
Patch queued for 4.17, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-28 14:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-26 14:15 [PATCH 0/2] video: s3c-fb: Adjustments for s3c_fb_probe() SF Markus Elfring
2017-11-26 14:16 ` [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe() SF Markus Elfring
2017-11-27 18:06 ` [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob Jingoo Han
2018-03-28 14:02 ` Bartlomiej Zolnierkiewicz
2017-11-26 14:17 ` [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe() SF Markus Elfring
2017-11-27 18:07 ` Jingoo Han
2018-03-28 14:05 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).