From: Jingoo Han <jg1.han@samsung.com>
To: 'Rashika Kheria' <rashika.kheria@gmail.com>,
'Andrew Morton' <akpm@linux-foundation.org>
Cc: 'Josh Triplett' <josh@joshtriplett.org>,
linux-kernel@vger.kernel.org,
'Jean-Christophe Plagniol-Villard' <plagnioj@jcrosoft.com>,
'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>,
'Eric Miao' <eric.y.miao@gmail.com>
Subject: Re: [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c
Date: Fri, 27 Dec 2013 02:21:04 +0000 [thread overview]
Message-ID: <000301cf02aa$4b1afef0$e150fcd0$%han@samsung.com> (raw)
In-Reply-To: <20131216142423.GB24172@leaf>
On Monday, December 16, 2013 11:24 PM, Josh Triplett wrote:
> On Mon, Dec 16, 2013 at 04:51:10PM +0530, Rashika Kheria wrote:
> > Removes unused function genericbl_limit_intensity() in
> > backlight/generic_bl.c.
> >
> > This eliminates the following warning in backlight/generic_bl.c:
> > drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for
> ‘genericbl_limit_intensity’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
(+cc Andrew Morton, Eric Miao)
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
>
> > drivers/video/backlight/generic_bl.c | 18 ------------------
> > 1 file changed, 18 deletions(-)
> >
> > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> > index 5d8d652..67dfb93 100644
> > --- a/drivers/video/backlight/generic_bl.c
> > +++ b/drivers/video/backlight/generic_bl.c
> > @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> > return genericbl_intensity;
> > }
> >
> > -/*
> > - * Called when the battery is low to limit the backlight intensity.
> > - * If limit=0 clear any limit, otherwise limit the intensity
> > - */
> > -void genericbl_limit_intensity(int limit)
> > -{
> > - struct backlight_device *bd = generic_backlight_device;
> > -
> > - mutex_lock(&bd->ops_lock);
> > - if (limit)
> > - bd->props.state |= GENERICBL_BATTLOW;
> > - else
> > - bd->props.state &= ~GENERICBL_BATTLOW;
> > - backlight_update_status(generic_backlight_device);
> > - mutex_unlock(&bd->ops_lock);
> > -}
> > -EXPORT_SYMBOL(genericbl_limit_intensity);
> > -
> > static const struct backlight_ops genericbl_ops = {
> > .options = BL_CORE_SUSPENDRESUME,
> > .get_brightness = genericbl_get_intensity,
> > --
> > 1.7.9.5
> >
prev parent reply other threads:[~2013-12-27 2:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 11:33 [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c Rashika Kheria
2013-12-16 11:34 ` Jingoo Han
2013-12-16 14:24 ` Josh Triplett
2013-12-27 2:21 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301cf02aa$4b1afef0$e150fcd0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=eric.y.miao@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rashika.kheria@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).