linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: 'Liu Ying' <Ying.Liu@freescale.com>
Cc: 'Jean-Christophe PLAGNIOL-VILLARD' <plagnioj@jcrosoft.com>,
	'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	'Jani Nikula' <jani.nikula@linux.intel.com>,
	'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH v4 0/2] backlight: update bl status and some bd properties when necessary
Date: Fri, 24 Jan 2014 08:20:44 +0000	[thread overview]
Message-ID: <000301cf18dd$2d3e9970$87bbcc50$%han@samsung.com> (raw)
In-Reply-To: <1390543476-13499-1-git-send-email-Ying.Liu@freescale.com>

On Friday, January 24, 2014 3:05 PM, Liu Ying wrote:
> 
> We don't have to turn backlight on/off every time a blanking
> or unblanking event comes because the backlight status may
> have already been what we want. Another thought is that one
> backlight device may be shared by multiple framebuffers. We
> don't hope blanking one of the framebuffers may turn the
> backlight off for all the other framebuffers, since they are
> likely being active to display something. This patch set adds
> some logics to record each framebuffer's backlight usage to
> determine the backlight device use count and whether the
> backlight status should be updated or not.
> 
> Liu Ying (2):
>   backlight: update bd state & fb_blank properties when necessary
>   backlight: update backlight status when necessary

Thank you for sending the v4 patch.
I have no objection against this patch. However, I will wait
for other people's opinions. Then, if there is no objection,
I will ask Andrew Morton to merge this patch into mm-tree.
Thanks.

Best regards,
Jingoo Han

> 
> v3->v4:
> * Split v3 into 2 patches to separate the change for updating the
>   backlight device properties and backlight status, according to
>   the comments from Jani Nikula and Jingoo Han.
> 
> v2->v3:
> * Set fb_blank(*(int *)evdata->data) to bd->props.fb_blank
>   when we turn off a blacklight.
> * Correct some trivial typos in the commit message.
> 
> v1->v2:
> * Make the commit message be more specific about the condition
>   in which backlight device use count can be increased/decreased.
> * Correct the setting for bd->props.fb_blank.
> 
>  drivers/video/backlight/backlight.c |   28 +++++++++++++++++++++-------
>  include/linux/backlight.h           |    6 ++++++
>  2 files changed, 27 insertions(+), 7 deletions(-)
> 
> --
> 1.7.9.5



      parent reply	other threads:[~2014-01-24  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24  6:04 [PATCH v4 0/2] backlight: update bl status and some bd properties when necessary Liu Ying
2014-01-24  6:04 ` [PATCH v4 1/2] backlight: update bd state & fb_blank " Liu Ying
2014-01-24  6:04 ` [PATCH v4 2/2] backlight: update backlight status " Liu Ying
2014-01-24  8:20 ` Jingoo Han [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000301cf18dd$2d3e9970$87bbcc50$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=Ying.Liu@freescale.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).