From: Jingoo Han <jg1.han@samsung.com>
To: "'Rafael J. Wysocki'" <rjw@sisk.pl>
Cc: 'Jean-Christophe PLAGNIOL-VILLARD' <plagnioj@jcrosoft.com>,
'Lars-Peter Clausen' <lars@metafoo.de>,
'Michael Hennerich' <michael.hennerich@analog.com>,
'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] PM: Add pm_sleep_ops_ptr() macro
Date: Tue, 04 Jun 2013 04:23:42 +0000 [thread overview]
Message-ID: <000601ce60db$4bd94e80$e38beb80$@samsung.com> (raw)
In-Reply-To: <3772829.L58vmUyOpk@vostro.rjw.lan>
On Tuesday, June 04, 2013 4:55 AM, Rafael J. Wysocki wrote:
> On Monday, June 03, 2013 01:11:07 PM Rafael J. Wysocki wrote:
> > On Monday, June 03, 2013 03:21:51 PM Jingoo Han wrote:
> > > Add pm_sleep_ops_ptr() macro that allows the .pm entry in the driver structures
> > > to be assigned without having an #define xxx NULL for the case that PM_SLEEP is
> > > not enabled.
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > Cc: Michael Hennerich <michael.hennerich@analog.com>
> >
> > Do you want me to replace the previous patch with this?
>
> Quite frankly, I prefer the previous version, which was more general.
>
> That is, what if someone wants to use that macro for runtime PM too?
>
> Honestly, I think we'll be better off without any of them, so I'm dropping
> the previous patch too for now.
OK, I see.
I agree with your opinion.
Also, as I mentioned, I want other's better ideas.
Best regards,
Jingoo Han
>
> Thanks,
> Rafael
>
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-06-04 4:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 6:21 [PATCH] PM: Add pm_sleep_ops_ptr() macro Jingoo Han
2013-06-03 11:11 ` Rafael J. Wysocki
2013-06-03 19:54 ` Rafael J. Wysocki
2013-06-04 4:23 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601ce60db$4bd94e80$e38beb80$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=plagnioj@jcrosoft.com \
--cc=rjw@sisk.pl \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).