linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock
@ 2012-12-14  8:33 Jonghwan Choi
  2012-12-17  1:31 ` Donghwa Lee
  0 siblings, 1 reply; 2+ messages in thread
From: Jonghwan Choi @ 2012-12-14  8:33 UTC (permalink / raw)
  To: linux-fbdev

Add a mutex_unlock on the error path.

Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 drivers/video/exynos/exynos_mipi_dsi_common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c
b/drivers/video/exynos/exynos_mipi_dsi_common.c
index 3cd29a4..bd7f4f2 100644
--- a/drivers/video/exynos/exynos_mipi_dsi_common.c
+++ b/drivers/video/exynos/exynos_mipi_dsi_common.c
@@ -377,6 +377,7 @@ int exynos_mipi_dsi_rd_data(struct mipi_dsim_device
*dsim, unsigned int data_id,
 			"data id %x is not supported current DSI spec.\n",
 			data_id);
 
+		mutex_unlock(&dsim->lock);
 		return -EINVAL;
 	}
 
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock
  2012-12-14  8:33 [PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock Jonghwan Choi
@ 2012-12-17  1:31 ` Donghwa Lee
  0 siblings, 0 replies; 2+ messages in thread
From: Donghwa Lee @ 2012-12-17  1:31 UTC (permalink / raw)
  To: linux-fbdev

  On Fri, Dec 14, 2012 at 17:33, Jonghwan Choi wrote:
> Add a mutex_unlock on the error path.
>
> Signed-off-by: Jonghwan Choi<jhbird.choi@samsung.com>
> ---
>   drivers/video/exynos/exynos_mipi_dsi_common.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c
> b/drivers/video/exynos/exynos_mipi_dsi_common.c
> index 3cd29a4..bd7f4f2 100644
> --- a/drivers/video/exynos/exynos_mipi_dsi_common.c
> +++ b/drivers/video/exynos/exynos_mipi_dsi_common.c
> @@ -377,6 +377,7 @@ int exynos_mipi_dsi_rd_data(struct mipi_dsim_device
> *dsim, unsigned int data_id,
>   			"data id %x is not supported current DSI spec.\n",
>   			data_id);
>   
> +		mutex_unlock(&dsim->lock);
>   		return -EINVAL;
>   	}
>   
It looks good to me.

Acked-by: Donghwa Lee <dh09.lee@samsung.com>

Thank you,
Donghwa Lee

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-17  1:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-14  8:33 [PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock Jonghwan Choi
2012-12-17  1:31 ` Donghwa Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).