From: Jingoo Han <jg1.han@samsung.com>
To: 'Dongjin Kim' <tobetter@gmail.com>
Cc: 'Dongjin Kim' <dongjin.kim@agreeyamobility.net>,
'Florian Tobias Schandinat' <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] video: s3c-fb: Fix compile error/warning if CONFIG_OF is not selected
Date: Tue, 07 Aug 2012 00:24:37 +0000 [thread overview]
Message-ID: <000a01cd7433$07555780$16000680$%han@samsung.com> (raw)
In-Reply-To: <1344261462-14183-5-git-send-email-dongjin.kim@agreeyamobility.net>
On Monday, August 06, 2012 10:58 PM Dongjin Kim wrote:
>
> Change-Id: I5d7ff6f0070a10225d5b064b362d3d8f214787fd
> Signed-off-by: Dongjin Kim <dongjin.kim@agreeyamobility.net>
> ---
> drivers/video/s3c-fb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 8c8adb5..268be0c 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1527,13 +1527,11 @@ static int s3c_fb_dt_parse_gpios(struct device *dev, struct s3c_fb *sfb,
>
> static void s3c_fb_dt_free_gpios(struct s3c_fb *sfb)
> {
> - return 0;
> }
>
> -static int s3c_fb_dt_parse_pdata(struct device *dev,
> - struct s3c_fb_platdata **pdata)
> +static struct s3c_fb_platdata *s3c_fb_dt_parse_pdata(struct device *dev)
> {
> - return 0;
> + return NULL;
> }
> #endif /* CONFIG_OF */
Um, DT is not yet merged to s3c-fb driver.
s3c_fb_dt_parse_pdata() and s3c_fb_dt_free_gpios() are not available.
So, this patch is unnecessary.
Best regards,
Jingoo Han
>
> --
> 1.7.9.5
next prev parent reply other threads:[~2012-08-07 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1344261462-14183-1-git-send-email-dongjin.kim@agreeyamobility.net>
2012-08-06 13:57 ` [PATCH] video: s3c-fb: Fix compile error/warning if CONFIG_OF is not selected Dongjin Kim
2012-08-07 0:24 ` Jingoo Han [this message]
2012-08-07 0:47 ` Dongjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000a01cd7433$07555780$16000680$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=dongjin.kim@agreeyamobility.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox