From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Date: Wed, 25 Apr 2012 01:19:15 +0000 Subject: RE: [PATCH] drivers/video/ep93xx-fb.c: clean up error-handling code Message-Id: <000e01cd2281$6ddd2ef0$49978cd0$%han@samsung.com> List-Id: References: <1334777828-3557-1-git-send-email-Julia.Lawall@lip6.fr> <4F8F5938.2000207@gmail.com> <000401cd1dd2$5f8ee3b0$1eacab10$%han@samsung.com> <1335271586.25429.19.camel@joe2Laptop> In-Reply-To: <1335271586.25429.19.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: 'Joe Perches' Cc: 'Ryan Mallon' , 'Florian Tobias Schandinat' , kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, 'Julia Lawall' , 'Jingoo Han' On Tue, 24 Apr 2012, Joe Perches wrote: > -----Original Message----- > On Thu, 2012-04-19 at 07:14 +0200, Julia Lawall wrote: > > I don't know thw impact of the ./. I use the options > > > > --nokeywords --nogit-fallback --subsystem --norolestats -f > > > > julia > > > > On Thu, 19 Apr 2012, Jingoo Han wrote: > > > > >> -----Original Message----- > > >> From: Ryan Mallon > [] > > >> Oddly, scripts/get_maintainer.pl on this file doesn't return me, even > > >> though, according to git blame, I am the author of 90% of the commit= s. > > >> Should I have an entry in the MAINTAINERS file, or is > > >> scripts/get_maintainer.pl not working properly? > > > > > > There are optional differences in using scripts/get_maintainer.pl. > > > If you use './' ahead of file path, you will see your name. > > > > > > Without './' ahead of 'drivers/video/ep93xx-fb.c': > > > ./scripts/get_maintainer.pl --file drivers/video/ep93xx-fb.c > > > Florian Tobias Schandinat (maintainer:FRAM= EBUFFER LAYER) > > > linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER) > > > linux-kernel@vger.kernel.org (open list) > > > > > > With './' ahead of 'drivers/video/ep93xx-fb.c': > > > ./scripts/get_maintainer.pl --file ./drivers/video/ep93xx-fb.c > > > Ryan Mallon (commit_signer:2/3g%) > > > Paul Gortmaker (commit_signer:1/33%) > > > H Hartley Sweeten (commit_signer:1/33%) > > > Jesper Juhl (commit_signer:1/33%) > > > Jiri Kosina (commit_signer:1/33%) > > > linux-kernel@vger.kernel.org (open list) >=20 > Prefixing "./" to the file path bypasses the normal > get_maintainers pattern check for file maintainership. >=20 > Florian Schandinat and linux-fbdev are not returned > in the second lookup above. >=20 > One of the patterns for FRAMEBUFFER is > F: drivers/video/ > which is a direct match for is ep93xx-fb.c file, > so --git is not used by default. >=20 > Adding --git may be appropriate and it also returns > Ryan's name in this case. >=20 > $ ./scripts/get_maintainer.pl -f drivers/video/ep93xx-fb.c > Florian Tobias Schandinat (maintainer:FRAMEBUF= FER LAYER) > linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER) > linux-kernel@vger.kernel.org (open list) >=20 > $ ./scripts/get_maintainer.pl --git -f drivers/video/ep93xx-fb.c > Florian Tobias Schandinat (maintainer:FRAMEBUF= FER LAYER) > Ryan Mallon (commit_signer:2/3g%) > Paul Gortmaker (commit_signer:1/33%) > H Hartley Sweeten (commit_signer:1/33%) > Jesper Juhl (commit_signer:1/33%) > Jiri Kosina (commit_signer:1/33%) > linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER) > linux-kernel@vger.kernel.org (open list) >=20 > Nominally, as framebuffer maintainer, Florian > should also have "signed-off" on these commits, > but many subsystems don't actually have a > single path or person for patches and commits. >=20 > This file came into the tree via Andrew Morton. >=20 > Another way to investigate who actually does > work on an individual file is to use the > get_maintainer.pl option "--interactive". Thank you for your reply. It is very helpful. Best regards, Jingoo Han >=20 > That can give you an output like: >=20 > * # email/list and role:stats aut= h sign > * 1 Florian Tobias Schandinat > maintainer:FRAMEBUFFER LAYER > * 2 Ryan Mallon = 4 4 > commit_signer:2/3g%,authored lines:645/650=99%,commits:4/8P% > * 3 Paul Gortmaker = 1 1 > commit_signer:1/33%,commits:1/8=12% > * 4 H Hartley Sweeten = 0 2 > commit_signer:1/33%,commits:2/8%% > * 5 Jesper Juhl = 0 1 > commit_signer:1/33% > * 6 Jiri Kosina = 0 1 > commit_signer:1/33% > * 7 Andrew Morton = 0 2 > commits:2/8%% > * 8 Russell King = 0 1 > commits:1/8=12% > * 9 linux-fbdev@vger.kernel.org > open list:FRAMEBUFFER LAYER > * 10 linux-kernel@vger.kernel.org > open list >=20 > About maintainership for individual files: >=20 > If anyone thinks they are the maintainer for > a particular file, generally they should submit > a patch to MAINTAINERS adding a section with > their name, maintainership level and an > appropriate file pattern.