From: Jingoo Han <jg1.han@samsung.com>
To: 'Michal Simek' <michal.simek@xilinx.com>,
'Jean-Christophe Plagniol-Villard' <plagnioj@jcrosoft.com>
Cc: 'Michal Simek' <monstr@monstr.eu>,
'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
'Geert Uytterhoeven' <geert@linux-m68k.org>,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH v3] video: xilinxfb: Fix compilation warning
Date: Thu, 25 Jul 2013 23:14:32 +0000 [thread overview]
Message-ID: <000e01ce898c$b865f740$2931e5c0$@samsung.com> (raw)
In-Reply-To: <b8701d73538d37495b41ef465440a6d5f3018870.1374759923.git.michal.simek@xilinx.com>
On Thursday, July 25, 2013 10:45 PM, Michal Simek wrote:
>
> regs_phys is phys_addr_t (u32 or u64).
> Lets use %pa printk format specifier.
>
> Fixes compilation warning introduced by:
> video: xilinxfb: Use drvdata->regs_phys instead of physaddr
> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
It looks good.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> Changes in v3:
> - Fix commit message reported by Geert
>
> Changes in v2:
> - Use %pa instead of casting
>
> ppc44x_defconfig
> Fixes regressions in v3.11-rc2
>
> ---
> drivers/video/xilinxfb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
> index f3d4a69..6629b29 100644
> --- a/drivers/video/xilinxfb.c
> +++ b/drivers/video/xilinxfb.c
> @@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev,
>
> if (drvdata->flags & BUS_ACCESS_FLAG) {
> /* Put a banner in the log (for DEBUG) */
> - dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys,
> - drvdata->regs);
> + dev_dbg(dev, "regs: phys=%pa, virt=%p\n",
> + &drvdata->regs_phys, drvdata->regs);
> }
> /* Put a banner in the log (for DEBUG) */
> dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n",
> --
> 1.8.2.3
>
next prev parent reply other threads:[~2013-07-25 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 13:45 [PATCH v3] video: xilinxfb: Fix compilation warning Michal Simek
2013-07-25 23:14 ` Jingoo Han [this message]
2013-07-26 7:33 ` Tomi Valkeinen
2013-07-26 7:35 ` Tomi Valkeinen
2013-07-26 8:27 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000e01ce898c$b865f740$2931e5c0$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).