* re: video: pxa3xx-gcu: switch to devres functions
@ 2014-04-02 11:15 Dan Carpenter
2014-04-03 0:04 ` Jingoo Han
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-04-02 11:15 UTC (permalink / raw)
To: linux-fbdev
Hello Daniel Mack,
The patch a9b47c7f2390: "video: pxa3xx-gcu: switch to devres
functions" from Mar 5, 2014, leads to the following static checker
warning:
drivers/video/fbdev/pxa3xx-gcu.c:616 pxa3xx_gcu_probe()
warn: 'priv->mmio_base' isn't an ERR_PTR
drivers/video/fbdev/pxa3xx-gcu.c
612
613 /* handle IO resources */
614 r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
615 priv->mmio_base = devm_request_and_ioremap(dev, r);
616 if (IS_ERR(priv->mmio_base)) {
devm_request_and_ioremap() returns NULL on error.
617 dev_err(dev, "failed to map I/O memory\n");
618 return PTR_ERR(priv->mmio_base);
619 }
620
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: video: pxa3xx-gcu: switch to devres functions
2014-04-02 11:15 video: pxa3xx-gcu: switch to devres functions Dan Carpenter
@ 2014-04-03 0:04 ` Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2014-04-03 0:04 UTC (permalink / raw)
To: linux-fbdev
On Wednesday, April 02, 2014 8:15 PM, Dan Carpenter wrote:
>
> Hello Daniel Mack,
>
> The patch a9b47c7f2390: "video: pxa3xx-gcu: switch to devres
> functions" from Mar 5, 2014, leads to the following static checker
> warning:
>
> drivers/video/fbdev/pxa3xx-gcu.c:616 pxa3xx_gcu_probe()
> warn: 'priv->mmio_base' isn't an ERR_PTR
>
> drivers/video/fbdev/pxa3xx-gcu.c
> 612
> 613 /* handle IO resources */
> 614 r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 615 priv->mmio_base = devm_request_and_ioremap(dev, r);
> 616 if (IS_ERR(priv->mmio_base)) {
>
> devm_request_and_ioremap() returns NULL on error.
Yes, you're right.
It should be replaced with devm_ioremap_resource().
I will send the patch, soon.
Best regards,
Jingoo Han
>
> 617 dev_err(dev, "failed to map I/O memory\n");
> 618 return PTR_ERR(priv->mmio_base);
> 619 }
> 620
>
> regards,
> dan carpenter
> --
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-03 0:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 11:15 video: pxa3xx-gcu: switch to devres functions Dan Carpenter
2014-04-03 0:04 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).