From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Date: Mon, 03 Jun 2013 04:10:10 +0000 Subject: Re: [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops Message-Id: <001a01ce6010$3daaf3c0$b900db40$@samsung.com> List-Id: References: <1370128047-2444-1-git-send-email-shuah.kh@samsung.com> In-Reply-To: <1370128047-2444-1-git-send-email-shuah.kh@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton , 'Shuah Khan' Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, shuahkhan@gmail.com, rpurdie@rpsys.net, FlorianSchandinat@gmx.de, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, rafael.j.wysocki@intel.com, Jingoo Han On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote: > > Convert drivers/video/backlight/class to use dev_pm_ops for power > management and remove Legacy PM ops hooks. With this change, backlight > class registers suspend/resume callbacks via class->pm (dev_pm_ops) > instead of Legacy class->suspend/resume. When __device_suspend() runs > call-backs, it will find class->pm ops for the backlight class. > > Signed-off-by: Shuah Khan > Cc: Shuah Khan CC'ed Andrew Morton, It looks good. Acked-by: Jingoo Han Best regards, Jingoo Han > --- > > v2: Updated changelog to correct device class. > v3: Updated changelog to correct device class. > > drivers/video/backlight/backlight.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index c74e7aa..0ffb251 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev, > > static struct class *backlight_class; > > -static int backlight_suspend(struct device *dev, pm_message_t state) > +static int backlight_suspend(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > > @@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev) > return 0; > } > > +static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, > + backlight_resume); > + > static void bl_device_release(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > @@ -414,8 +417,7 @@ static int __init backlight_class_init(void) > } > > backlight_class->dev_attrs = bl_device_attributes; > - backlight_class->suspend = backlight_suspend; > - backlight_class->resume = backlight_resume; > + backlight_class->pm = &backlight_class_dev_pm_ops; > return 0; > } > > -- > 1.7.10.4 >