* [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops
@ 2013-06-01 23:07 Shuah Khan
2013-06-03 4:10 ` Jingoo Han
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2013-06-01 23:07 UTC (permalink / raw)
To: rpurdie, FlorianSchandinat, plagnioj, tomi.valkeinen,
rafael.j.wysocki
Cc: Shuah Khan, linux-fbdev, linux-kernel, shuahkhan
Convert drivers/video/backlight/class to use dev_pm_ops for power
management and remove Legacy PM ops hooks. With this change, backlight
class registers suspend/resume callbacks via class->pm (dev_pm_ops)
instead of Legacy class->suspend/resume. When __device_suspend() runs
call-backs, it will find class->pm ops for the backlight class.
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
Cc: Shuah Khan <shuahkhan@gmail.com>
---
v2: Updated changelog to correct device class.
v3: Updated changelog to correct device class.
drivers/video/backlight/backlight.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index c74e7aa..0ffb251 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev,
static struct class *backlight_class;
-static int backlight_suspend(struct device *dev, pm_message_t state)
+static int backlight_suspend(struct device *dev)
{
struct backlight_device *bd = to_backlight_device(dev);
@@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev)
return 0;
}
+static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend,
+ backlight_resume);
+
static void bl_device_release(struct device *dev)
{
struct backlight_device *bd = to_backlight_device(dev);
@@ -414,8 +417,7 @@ static int __init backlight_class_init(void)
}
backlight_class->dev_attrs = bl_device_attributes;
- backlight_class->suspend = backlight_suspend;
- backlight_class->resume = backlight_resume;
+ backlight_class->pm = &backlight_class_dev_pm_ops;
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops
2013-06-01 23:07 [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops Shuah Khan
@ 2013-06-03 4:10 ` Jingoo Han
2013-06-06 21:27 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-06-03 4:10 UTC (permalink / raw)
To: Andrew Morton, 'Shuah Khan'
Cc: linux-fbdev, linux-kernel, shuahkhan, rpurdie, FlorianSchandinat,
plagnioj, tomi.valkeinen, rafael.j.wysocki, Jingoo Han
On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:
>
> Convert drivers/video/backlight/class to use dev_pm_ops for power
> management and remove Legacy PM ops hooks. With this change, backlight
> class registers suspend/resume callbacks via class->pm (dev_pm_ops)
> instead of Legacy class->suspend/resume. When __device_suspend() runs
> call-backs, it will find class->pm ops for the backlight class.
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> Cc: Shuah Khan <shuahkhan@gmail.com>
CC'ed Andrew Morton,
It looks good.
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
>
> v2: Updated changelog to correct device class.
> v3: Updated changelog to correct device class.
>
> drivers/video/backlight/backlight.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
> index c74e7aa..0ffb251 100644
> --- a/drivers/video/backlight/backlight.c
> +++ b/drivers/video/backlight/backlight.c
> @@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev,
>
> static struct class *backlight_class;
>
> -static int backlight_suspend(struct device *dev, pm_message_t state)
> +static int backlight_suspend(struct device *dev)
> {
> struct backlight_device *bd = to_backlight_device(dev);
>
> @@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev)
> return 0;
> }
>
> +static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend,
> + backlight_resume);
> +
> static void bl_device_release(struct device *dev)
> {
> struct backlight_device *bd = to_backlight_device(dev);
> @@ -414,8 +417,7 @@ static int __init backlight_class_init(void)
> }
>
> backlight_class->dev_attrs = bl_device_attributes;
> - backlight_class->suspend = backlight_suspend;
> - backlight_class->resume = backlight_resume;
> + backlight_class->pm = &backlight_class_dev_pm_ops;
> return 0;
> }
>
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops
2013-06-03 4:10 ` Jingoo Han
@ 2013-06-06 21:27 ` Arnd Bergmann
2013-06-07 1:29 ` Jingoo Han
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2013-06-06 21:27 UTC (permalink / raw)
To: Jingoo Han
Cc: Andrew Morton, 'Shuah Khan', linux-fbdev, linux-kernel,
shuahkhan, rpurdie, FlorianSchandinat, plagnioj, tomi.valkeinen,
rafael.j.wysocki
On Monday 03 June 2013 13:10:10 Jingoo Han wrote:
> On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:
> >
> > Convert drivers/video/backlight/class to use dev_pm_ops for power
> > management and remove Legacy PM ops hooks. With this change, backlight
> > class registers suspend/resume callbacks via class->pm (dev_pm_ops)
> > instead of Legacy class->suspend/resume. When __device_suspend() runs
> > call-backs, it will find class->pm ops for the backlight class.
> >
> > Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> > Cc: Shuah Khan <shuahkhan@gmail.com>
>
> CC'ed Andrew Morton,
>
> It looks good.
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
>
I'm getting this build warning now:
arnd@wuerfel:/git/arm-soc$ cat build/omap1_defconfig/faillog
/git/arm-soc/drivers/video/backlight/backlight.c:212:12: warning: 'backlight_suspend' defined but not used [-Wunused-function]
static int backlight_suspend(struct device *dev)
^
/git/arm-soc/drivers/video/backlight/backlight.c:226:12: warning: 'backlight_resume' defined but not used [-Wunused-function]
static int backlight_resume(struct device *dev)
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops
2013-06-06 21:27 ` Arnd Bergmann
@ 2013-06-07 1:29 ` Jingoo Han
0 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-06-07 1:29 UTC (permalink / raw)
To: 'Arnd Bergmann'
Cc: 'Andrew Morton', 'Shuah Khan', linux-fbdev,
linux-kernel, shuahkhan, rpurdie, FlorianSchandinat, plagnioj,
tomi.valkeinen, rafael.j.wysocki, Jingoo Han
On Friday, June 07, 2013 6:28 AM, Arnd Bergmann wrote:
> On Monday 03 June 2013 13:10:10 Jingoo Han wrote:
> > On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:
> > >
> > > Convert drivers/video/backlight/class to use dev_pm_ops for power
> > > management and remove Legacy PM ops hooks. With this change, backlight
> > > class registers suspend/resume callbacks via class->pm (dev_pm_ops)
> > > instead of Legacy class->suspend/resume. When __device_suspend() runs
> > > call-backs, it will find class->pm ops for the backlight class.
> > >
> > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> > > Cc: Shuah Khan <shuahkhan@gmail.com>
> >
> > CC'ed Andrew Morton,
> >
> > It looks good.
> >
> > Acked-by: Jingoo Han <jg1.han@samsung.com>
> >
>
> I'm getting this build warning now:
>
> arnd@wuerfel:/git/arm-soc$ cat build/omap1_defconfig/faillog
> /git/arm-soc/drivers/video/backlight/backlight.c:212:12: warning: 'backlight_suspend' defined but not
> used [-Wunused-function]
> static int backlight_suspend(struct device *dev)
> ^
> /git/arm-soc/drivers/video/backlight/backlight.c:226:12: warning: 'backlight_resume' defined but not
> used [-Wunused-function]
> static int backlight_resume(struct device *dev)
Hi Arnd Bergmann,
I see what happens.
This build warning happens when CONFIG_PM is selected and
CONFIG_PM_SLEEP is not selected.
So, I will add '#ifdef CONFIG_PM_SLEEP' to './drivers/video/backlight/backlight.c'
and send it soon.
Thank you.
Best regards,
Jingoo Han
>
> Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-07 1:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01 23:07 [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops Shuah Khan
2013-06-03 4:10 ` Jingoo Han
2013-06-06 21:27 ` Arnd Bergmann
2013-06-07 1:29 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).