From: Jingoo Han <jg1.han@samsung.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH Re-send] pwm-backlight: Use devm_pwm_get in pwm_bl.c
Date: Mon, 17 Sep 2012 09:40:19 +0000 [thread overview]
Message-ID: <001e01cd94b8$73939ec0$5abadc40$%han@samsung.com> (raw)
In-Reply-To: <1347862847-2774-1-git-send-email-sachin.kamat@linaro.org>
On Monday, September 17, 2012 6:33 PM Thierry Reding wrote
>
> On Mon, Sep 17, 2012 at 11:50:47AM +0530, Sachin Kamat wrote:
> > This file already makes use of device managed functions.
> > Convert pwm_get() too to use it.
>
> I find this description a bit confusing. pwm_get() is not converted, but
> rather the driver is converted to use devm_pwm_get() instead of
> pwm_get().
>
> How about this:
>
> pwm-backlight: Use devm_pwm_get() instead of pwm_get()
>
> Managed versions of the pwm_get() and pwm_put() functions were recently
> added to the PWM framework. They can be used to simplify cleanup in the
> error paths and the device removal callback.
>
It looks good.
Sachin, how about you?
Best regards,
Jingoo Han
> If that's okay with you, I can just replace it before pushing so there's
> no need for you to resend.
>
> Thierry
next prev parent reply other threads:[~2012-09-17 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 6:32 [PATCH Re-send] pwm-backlight: Use devm_pwm_get in pwm_bl.c Sachin Kamat
2012-09-17 9:33 ` Thierry Reding
2012-09-17 9:40 ` Jingoo Han [this message]
2012-09-17 9:52 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001e01cd94b8$73939ec0$5abadc40$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox