From: Jingoo Han <jg1.han@samsung.com>
To: 'Tomi Valkeinen' <tomi.valkeinen@ti.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, FlorianSchandinat@gmx.de,
s.trumtrar@pengutronix.de, plagnioj@jcrosoft.com,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo
Date: Fri, 05 Apr 2013 08:02:57 +0000 [thread overview]
Message-ID: <002601ce31d3$fc25cfc0$f4716f40$%han@samsung.com> (raw)
In-Reply-To: <515E75BC.20604@ti.com>
On Friday, April 05, 2013 3:57 PM, Tomi Valkeinen wrote:
>
> Hi,
>
> On 2013-03-29 03:40, Jingoo Han wrote:
> > VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH,
> > because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > drivers/video/fbmon.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> > index 94ad0f7..7f67099 100644
> > --- a/drivers/video/fbmon.c
> > +++ b/drivers/video/fbmon.c
> > @@ -1400,7 +1400,7 @@ int fb_videomode_from_videomode(const struct videomode *vm,
> > fbmode->vmode = 0;
> > if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> > fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;
> > - if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> > + if (vm->dmt_flags & VESA_DMT_VSYNC_HIGH)
> > fbmode->sync |= FB_SYNC_VERT_HIGH_ACT;
> > if (vm->data_flags & DISPLAY_FLAGS_INTERLACED)
> > fbmode->vmode |= FB_VMODE_INTERLACED;
>
> I'll apply this to fbdev fixes.
Oh, thank you. :)
Best regards,
Jingoo Han
>
> Tomi
>
>
prev parent reply other threads:[~2013-04-05 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 1:40 [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo Jingoo Han
2013-03-29 8:41 ` Steffen Trumtrar
2013-04-05 6:57 ` Tomi Valkeinen
2013-04-05 8:02 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002601ce31d3$fc25cfc0$f4716f40$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=s.trumtrar@pengutronix.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).