linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] vga16fb: remove an unused variable
@ 2013-07-31  8:54 Dan Carpenter
  2013-07-31  9:02 ` Jingoo Han
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-07-31  8:54 UTC (permalink / raw)
  To: linux-fbdev

Commit e21d2170f3 "video: remove unnecessary platform_set_drvdata()"
introduces an unused variable compile warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
 
 static void vga16fb_destroy(struct fb_info *info)
 {
-	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
 	iounmap(info->screen_base);
 	fb_dealloc_cmap(&info->cmap);
 	/* XXX unshare VGA regions */

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] vga16fb: remove an unused variable
  2013-07-31  8:54 [patch] vga16fb: remove an unused variable Dan Carpenter
@ 2013-07-31  9:02 ` Jingoo Han
  0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-07-31  9:02 UTC (permalink / raw)
  To: linux-fbdev

On Wednesday, July 31, 2013 5:54 PM, Dan Carpenter wrote:
> 
> Commit e21d2170f3 "video: remove unnecessary platform_set_drvdata()"
> introduces an unused variable compile warning.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Hi Dan Carpenter,

The same patch was submitted by Luis Henriques 2 weeks ago. :)
Also, the patch was already applied by Tomi Valkeinen.
It will be merged to 3.11-rc4.
Thank you for caring it.

Best regards,
Jingoo Han


> 
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
> 
>  static void vga16fb_destroy(struct fb_info *info)
>  {
> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>  	iounmap(info->screen_base);
>  	fb_dealloc_cmap(&info->cmap);
>  	/* XXX unshare VGA regions */


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-31  9:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31  8:54 [patch] vga16fb: remove an unused variable Dan Carpenter
2013-07-31  9:02 ` Jingoo Han

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).