From: Jingoo Han <jg1.han@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH] video: s3c-fb: Add device tree support
Date: Wed, 11 Jan 2012 09:16:54 +0000 [thread overview]
Message-ID: <004401ccd041$c2f66100$48e32300$%han@samsung.com> (raw)
In-Reply-To: <1326139307-25112-1-git-send-email-thomas.abraham@linaro.org>
Hi, Thomas.
> -----Original Message-----
> From: Thomas Abraham [mailto:thomas.abraham@linaro.org]
> Sent: Tuesday, January 10, 2012 5:02 AM
> To: linux-fbdev@vger.kernel.org; devicetree-discuss@lists.ozlabs.org
> Cc: FlorianSchandinat@gmx.de; grant.likely@secretlab.ca; rob.herring@calxeda.com; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; kgene.kim@samsung.com;
> jg1.han@samsung.com; patches@linaro.org
> Subject: [PATCH] video: s3c-fb: Add device tree support
>
> Add device tree based discovery support for Samsung's display controller.
>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> ---
> .../devicetree/bindings/fb/samsung-fb.txt | 103 ++++++++++
> drivers/video/s3c-fb.c | 209 +++++++++++++++++++-
> 2 files changed, 304 insertions(+), 8 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/fb/samsung-fb.txt
>
> [...]
>
> +- samsung,fimd-bpp: Specifies the bits per pixel. Two values should be
> + specified in the following order.
> + - max-bpp: maximum required bpp for the overlay.
> + - default-bpp: bpp supported by the overlay.
> [...]
> + fimd-overlay0 {
> + samsung,fimd-htiming = <64 16 48 1024>;
> + samsung,fimd-vtiming = <64 16 3 600>;
> + samsung,fimd-bpp = <24 32>;
> + };
> +
> + fimd-overlay1 {
> + samsung,fimd-htiming = <64 16 48 200>;
> + samsung,fimd-vtiming = <64 16 3 100>;
> + samsung,fimd-bpp = <16 32>;
> + };
> + };
In the above 'samsung-fb.txt', the order is defined as max-bpp and default-bpp.
However, <24 32> and <16 32> seems to be wrong.
It should be <32 24> and <32 16>, respectively.
Max bpp would be 32bpp in s3c-fb.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2012-01-11 9:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 19:59 [PATCH] video: s3c-fb: Add device tree support Thomas Abraham
2012-01-10 4:52 ` Mark Brown
2012-01-11 11:16 ` Thomas Abraham
2012-01-11 17:40 ` Mark Brown
2012-01-11 9:16 ` Jingoo Han [this message]
2012-01-11 11:23 ` Thomas Abraham
2012-01-13 21:03 ` Sylwester Nawrocki
2012-01-13 21:30 ` Sylwester Nawrocki
2012-01-17 5:26 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004401ccd041$c2f66100$48e32300$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).