linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pawel Osciak <p.osciak@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha
Date: Fri, 02 Jul 2010 14:53:54 +0000	[thread overview]
Message-ID: <004501cb19f6$6416dbe0$2c4493a0$%osciak@samsung.com> (raw)
In-Reply-To: <4C2DE691.6050209@simtec.co.uk>

>Ben Dooks <ben@simtec.co.uk> wrote:
>On 28/06/10 09:08, Pawel Osciak wrote:
>> S3C64xx and S5P OSD registers for OSD size and alpha are as follows:
>> VIDOSDC: win 0 - size, win 1-4: alpha
>> VIDOSDD: win 1-2 - size; not present for windows 0, 3 and 4
>>
>> Signed-off-by: Pawel Osciak <p.osciak@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  drivers/video/s3c-fb.c |   58 ++++++++++++++++++++++++++++++++++++++++++--
>---
>>  1 files changed, 51 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
>> index 94423c5..3b2c7fe 100644
>> --- a/drivers/video/s3c-fb.c
>> +++ b/drivers/video/s3c-fb.c
>> @@ -64,6 +64,9 @@ struct s3c_fb;
>>  #define VIDOSD_B(win, variant) (OSD_BASE(win, variant) + 0x04)
>>  #define VIDOSD_C(win, variant) (OSD_BASE(win, variant) + 0x08)
>>  #define VIDOSD_D(win, variant) (OSD_BASE(win, variant) + 0x0C)
>> +#define VIDOSD_SIZE(win, variant, win_variant) \
>> +	(OSD_BASE(win, variant) + (win_variant).osd_size_off)
>> +#define VIDOSD_ALPHA(win, variant, win_variant) VIDOSD_C(win, variant)
>
>hmm, this is becoming a bit complicated. if we have a function to
>set it then maybe we should just calculate it there.
>

>> @@ -1445,12 +1478,17 @@ static int s3c_fb_resume(struct platform_device
>*pdev)
>>  static struct s3c_fb_win_variant s3c_fb_data_64xx_wins[] __devinitdata = {
>>  	[0] = {
>>  		.has_osd_c	= 1,
>> +		.has_osd_size	= 1,
>> +		.osd_size_off	= 0x8,
>>  		.palette_sz	= 256,
>>  		.valid_bpp	= VALID_BPP1248 | VALID_BPP(16) | VALID_BPP(24),
>>  	},
>>  	[1] = {
>>  		.has_osd_c	= 1,
>>  		.has_osd_d	= 1,
>> +		.has_osd_size	= 1,
>> +		.osd_size_off	= 0x12,
>> +		.has_osd_alpha	= 1,
>
>how about osd_size_off !=0 => has_osd_size ?
>

Could be done that way, yes... I'm not aware of any SoC with osd_size_off = 0
till now.

>do we need to change the osd c and d definitions?

I'd prefer not using "OSD_C" and "OSD_D" names at all. How they are changing
their usage across hw versions and windows is confusing enough. Maybe we should
only be using osd_sizeand osd_alpha instead? Would you agree?


Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center






  reply	other threads:[~2010-07-02 14:53 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-28  8:08 [PATCH v3 0/12] Various s3c-fb updates Pawel Osciak
2010-06-28  8:08 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer Pawel Osciak
2010-07-02  9:51   ` Ben Dooks
2010-07-02 12:56     ` [PATCH v3 01/12] s3c-fb: Fix various null references on Pawel Osciak
2010-07-06 16:16     ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer James Simmons
2010-06-28  8:08 ` [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for Pawel Osciak
2010-07-02 10:51   ` Ben Dooks
2010-06-28  8:08 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer Pawel Osciak
2010-07-02 11:12   ` Ben Dooks
2010-07-02 13:05     ` Pawel Osciak
2010-06-28  8:08 ` [PATCH v3 04/12] s3c-fb: Add device name initialization Pawel Osciak
2010-07-02 11:13   ` Ben Dooks
2010-06-28  8:08 ` [PATCH v3 05/12] s3c-fb: Add support for display panning Pawel Osciak
2010-06-28 11:28   ` Maurus Cuelenaere
2010-07-02 11:25     ` Ben Dooks
2010-07-02 11:33       ` Maurus Cuelenaere
2010-07-02 11:52       ` Mark Brown
2010-07-02 11:24   ` Ben Dooks
2010-07-02 13:29     ` Pawel Osciak
2010-07-04 13:50       ` Jamie Lokier
2010-06-28  8:08 ` [PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl Pawel Osciak
2010-07-02 11:37   ` Ben Dooks
2010-07-02 14:39     ` Pawel Osciak
2010-06-28  8:08 ` [PATCH v3 07/12] s3c-fb: window 3 of 64xx+ does not have an osd_d Pawel Osciak
2010-06-28  8:08 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support Pawel Osciak
2010-07-02 13:11   ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking Ben Dooks
2010-07-02 14:45     ` Pawel Osciak
2010-06-28  8:08 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register Pawel Osciak
2010-07-02 13:16   ` Ben Dooks
2010-07-02 14:53     ` Pawel Osciak [this message]
2010-06-28  8:08 ` [PATCH v3 10/12] s3c-fb: Protect window-specific registers during Pawel Osciak
2010-06-28  8:08 ` [PATCH v3 11/12] s3c-fb: fix section mismatch Pawel Osciak
2010-06-28  8:08 ` [PATCH v3 12/12] s3c-fb: Add support for DMA channel control on S5PV210 Pawel Osciak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004501cb19f6$6416dbe0$2c4493a0$%osciak@samsung.com' \
    --to=p.osciak@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).