From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Date: Thu, 04 Oct 2012 01:33:38 +0000 Subject: Re: [PATCH 0/6] OMAPDSS: remove cpu_is_* calls Message-Id: <005d01cda1d0$47a249e0$d6e6dda0$%han@samsung.com> List-Id: References: <1348828527-13309-1-git-send-email-tomi.valkeinen@ti.com> In-Reply-To: <1348828527-13309-1-git-send-email-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Tomi Valkeinen' Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, 'Archit Taneja' , 'Chandrabhanu Mahapatra' , =?UTF-8?Q?'Rapha=C3=ABl_Ass=C3=A9nat'?= , 'Tony Lindgren' , 'Jingoo Han' On Friday, September 28, 2012 7:35 PM Tomi Valkeinen wrote > > Hi, > > This series adds an omapdss_version enum that is passed via platform data to > omapdss driver. This version identifier is then used instead of cpu_is_*() > calls. Hi Tomi, As you mentioned, cpu_is_*() is not preferable in driver. Actually, I thought so, when I saw the OMAPDSS driver a few months ago. Anyway, it looks good. :) Best regards, Jingoo Han > > After these, omapdss no longer contains any plat/ or mach/ includes. omapfb, > vrfb and vram still do, though. > > Tomi > > Tomi Valkeinen (6): > OMAPDSS: add omapdss_version > OMAPDSS: use omapdss_version in dss_features.c > OMAPDSS: DISPC: use omapdss_version > OMAPDSS: DSS: use omapdss_version > OMAPDSS: HDMI: use omapdss_version > OMAPDSS: remove includes > > arch/arm/mach-omap2/display.c | 38 +++++++++++++++++++ > drivers/video/omap2/dss/core.c | 2 +- > drivers/video/omap2/dss/dispc.c | 41 +++++++++++++------- > drivers/video/omap2/dss/dss.c | 39 +++++++++++++------ > drivers/video/omap2/dss/dss_features.c | 64 ++++++++++++++++++++++---------- > drivers/video/omap2/dss/dss_features.h | 5 ++- > drivers/video/omap2/dss/hdmi.c | 3 +- > include/video/omapdss.h | 14 +++++++ > 8 files changed, 157 insertions(+), 49 deletions(-) > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html