From: Jingoo Han <jg1.han@samsung.com>
To: 'Ajay kumar' <ajaynumb@gmail.com>, linux-fbdev@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org, FlorianSchandinat@gmx.de,
thomas.ab@samsung.com,
'devicetree-discuss' <devicetree-discuss@lists.ozlabs.org>,
'Sylwester Nawrocki' <sylvester.nawrocki@gmail.com>,
'Tomasz Figa' <tomasz.figa@gmail.com>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH V3] video: exynos_dp: Add device tree support to DP driver
Date: Thu, 04 Oct 2012 01:50:17 +0000 [thread overview]
Message-ID: <005f01cda1d2$9b123c00$d136b400$%han@samsung.com> (raw)
In-Reply-To: <CAEC9eQNFos4Sw57eubX-USEjKBnKf9ETeWCU_sT1vdX3MgN4dA@mail.gmail.com>
On Monday, October 01, 2012 2:40 PM Ajay kumar wrote
>
> On Fri, Sep 28, 2012 at 5:41 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> > On Thursday, September 27, 2012 10:45 PM Sylwester Nawrocki wrote
> >> On 09/24/2012 09:36 PM, Ajay Kumar wrote:
[...]
> >> > +Example:
> >> > +
> >> > +SOC specific portion:
> >> > + dptx_phy: dptx_phy@0x10040720 {
> >> > + compatible = "samsung,dp-phy";
> >> > + samsung,dptx_phy_reg =<0x10040720>;
> >> > + samsung,enable_bit =<1>;
> >> > + };
> >> > +
> >> > + display-port-controller {
> >> > + compatible = "samsung,exynos5-dp";
> >> > + reg =<0x145B0000 0x10000>;
> >> > + interrupts =<10 3>;
> >> > + interrupt-parent =<&combiner>;
> >> > + dp_phy =<&dptx_phy>;
> >>
> >> Shouldn't it be "samsung,dp_phy" ?
> >
> > Do you mean this ? It is not working.
> > + dp_phy = "samsung,dp_phy";
> I din't get this.
> What do I need to change here?
As Tomasz Figa mentioned, it means that
-+ dp_phy =<&dptx_phy>;
++ samsung,dp_phy =<&dptx_phy>;
It is because this is a Samsung-specific property.
Best regards,
Jingoo Han
prev parent reply other threads:[~2012-10-04 1:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 12:45 [PATCH V3] video: exynos_dp: Add device tree support to DP driver Ajay Kumar
2012-09-27 7:58 ` Jingoo Han
[not found] ` <1348515385-22332-1-git-send-email-ajaykumar.rs-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-09-27 13:44 ` Sylwester Nawrocki
2012-09-28 0:11 ` Jingoo Han
2012-09-28 6:48 ` Tomasz Figa
2012-09-28 8:09 ` Jingoo Han
2012-09-28 8:25 ` Sylwester Nawrocki
2012-10-01 5:52 ` Ajay kumar
2012-10-04 1:50 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005f01cda1d2$9b123c00$d136b400$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=ajaynumb@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=thomas.ab@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).