* [PATCH V8 1/5] ARM: EXYNOS4: Change clock name for FIMD
@ 2011-07-20 22:54 Jingoo Han
2011-07-21 7:16 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2011-07-20 22:54 UTC (permalink / raw)
To: Kukjin Kim, Paul Mundt, linux-samsung-soc, linux-fbdev
Cc: Jonghun Han, Ben Dooks, Jingoo Han
This patch changes clock for FIMD from 'fimd' to 'lcd'.
Also, devname for FIMD is changed from 's5pv310-fb' to 'exynos4-fb'.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
arch/arm/mach-exynos4/clock.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-exynos4/clock.c
index 98b5cc4..778a202 100644
--- a/arch/arm/mach-exynos4/clock.c
+++ b/arch/arm/mach-exynos4/clock.c
@@ -405,13 +405,13 @@ static struct clk init_clocks_off[] = {
.enable = exynos4_clk_ip_cam_ctrl,
.ctrlbit = (1 << 3),
}, {
- .name = "fimd",
- .devname = "s5pv310-fb.0",
+ .name = "lcd",
+ .devname = "exynos4-fb.0",
.enable = exynos4_clk_ip_lcd0_ctrl,
.ctrlbit = (1 << 0),
}, {
- .name = "fimd",
- .devname = "s5pv310-fb.1",
+ .name = "lcd",
+ .devname = "exynos4-fb.1",
.enable = exynos4_clk_ip_lcd1_ctrl,
.ctrlbit = (1 << 0),
}, {
@@ -909,7 +909,7 @@ static struct clksrc_clk clksrcs[] = {
}, {
.clk = {
.name = "sclk_fimd",
- .devname = "s5pv310-fb.0",
+ .devname = "exynos4-fb.0",
.enable = exynos4_clksrc_mask_lcd0_ctrl,
.ctrlbit = (1 << 0),
},
@@ -919,7 +919,7 @@ static struct clksrc_clk clksrcs[] = {
}, {
.clk = {
.name = "sclk_fimd",
- .devname = "s5pv310-fb.1",
+ .devname = "exynos4-fb.1",
.enable = exynos4_clksrc_mask_lcd1_ctrl,
.ctrlbit = (1 << 0),
},
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH V8 1/5] ARM: EXYNOS4: Change clock name for FIMD
2011-07-20 22:54 [PATCH V8 1/5] ARM: EXYNOS4: Change clock name for FIMD Jingoo Han
@ 2011-07-21 7:16 ` Kukjin Kim
2011-08-30 14:56 ` Tushar Behera
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2011-07-21 7:16 UTC (permalink / raw)
To: 'Jingoo Han', 'Paul Mundt', linux-samsung-soc,
linux-fbdev
Cc: 'Jonghun Han', 'Ben Dooks'
Jingoo Han wrote:
>
> This patch changes clock for FIMD from 'fimd' to 'lcd'.
> Also, devname for FIMD is changed from 's5pv310-fb' to 'exynos4-fb'.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/mach-exynos4/clock.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-exynos4/clock.c
> index 98b5cc4..778a202 100644
> --- a/arch/arm/mach-exynos4/clock.c
> +++ b/arch/arm/mach-exynos4/clock.c
> @@ -405,13 +405,13 @@ static struct clk init_clocks_off[] = {
> .enable = exynos4_clk_ip_cam_ctrl,
> .ctrlbit = (1 << 3),
> }, {
> - .name = "fimd",
> - .devname = "s5pv310-fb.0",
> + .name = "lcd",
> + .devname = "exynos4-fb.0",
> .enable = exynos4_clk_ip_lcd0_ctrl,
> .ctrlbit = (1 << 0),
> }, {
> - .name = "fimd",
> - .devname = "s5pv310-fb.1",
> + .name = "lcd",
As I remember, some guys discussed about the clock name before.
Please refer to the following diagram. Before EXYNOS4210 clk 'lcd' was used
for FIMD IP core clock and source of the LCD pixel clock. But the mux used
to select source of LCD pixel clock is removed. So 'lcd' clock is only used
for core clock of FIMD IP. It isn't used for LCD pixel clock.
As a result clock name was changed from lcd to fimd in the EXYNOS4210
datasheet.
Before EXYNOS4
------------------------------------
dsys bus
----------------+-------------------
|
|1.clk 'lcd'
|
| FIMD block
+---+-----------+
4.mout_mpll |\ | | |
--------|m| | +-+-+ +----+ |
|u|-+ | | +-+core| |
|x| | | | +----+ |
|/ | | | |\ |
| | +-|m| +---+ |
| | |u|--+div| |
+------+---|x| +---+ |
2.SCLK_FIMD | |/ | |
| | |
+----------+----+
|
inside of SoC |
-----------------------+--------------------------
outside of SoC |
| 3.LCD pixel clock
|
+--------------+
| LCD module |
+--------------+
EXYNOS4210
------------------------------------
dsys bus
----------------+-------------------
|
|1.clk 'fimd'
|
| FIMD block
+---+-----------+
4.mout_mpll |\ | | |
--------|m| | | +----+ |
|u|-+ | +---+core| |
|x| | | +----+ |
|/ | | |
| | +---+ |
| | +--+div| |
+------+-----+ +---+ |
2.SCLK_FIMD | | |
| | |
+----------+----+
|
inside of SoC |
-----------------------+--------------------------
outside of SoC |
| 3.LCD pixel clock
|
+--------------+
| LCD module |
+--------------+
To change devname is ok to me. So will apply only it.
If any problems, please let me know :)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> + .devname = "exynos4-fb.1",
> .enable = exynos4_clk_ip_lcd1_ctrl,
> .ctrlbit = (1 << 0),
> }, {
> @@ -909,7 +909,7 @@ static struct clksrc_clk clksrcs[] = {
> }, {
> .clk = {
> .name = "sclk_fimd",
> - .devname = "s5pv310-fb.0",
> + .devname = "exynos4-fb.0",
> .enable = exynos4_clksrc_mask_lcd0_ctrl,
> .ctrlbit = (1 << 0),
> },
> @@ -919,7 +919,7 @@ static struct clksrc_clk clksrcs[] = {
> }, {
> .clk = {
> .name = "sclk_fimd",
> - .devname = "s5pv310-fb.1",
> + .devname = "exynos4-fb.1",
> .enable = exynos4_clksrc_mask_lcd1_ctrl,
> .ctrlbit = (1 << 0),
> },
> --
> 1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V8 1/5] ARM: EXYNOS4: Change clock name for FIMD
2011-07-21 7:16 ` Kukjin Kim
@ 2011-08-30 14:56 ` Tushar Behera
0 siblings, 0 replies; 3+ messages in thread
From: Tushar Behera @ 2011-08-30 14:56 UTC (permalink / raw)
To: Kukjin Kim
Cc: 'Jingoo Han', 'Paul Mundt', linux-samsung-soc,
linux-fbdev, 'Jonghun Han', 'Ben Dooks'
On Thursday 21 July 2011 12:46 PM, Kukjin Kim wrote:
> Jingoo Han wrote:
>>
>> This patch changes clock for FIMD from 'fimd' to 'lcd'.
>> Also, devname for FIMD is changed from 's5pv310-fb' to 'exynos4-fb'.
>>
>> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
>> ---
>> arch/arm/mach-exynos4/clock.c | 12 ++++++------
>> 1 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-exynos4/clock.c
>> index 98b5cc4..778a202 100644
>> --- a/arch/arm/mach-exynos4/clock.c
>> +++ b/arch/arm/mach-exynos4/clock.c
>> @@ -405,13 +405,13 @@ static struct clk init_clocks_off[] = {
>> .enable = exynos4_clk_ip_cam_ctrl,
>> .ctrlbit = (1<< 3),
>> }, {
>> - .name = "fimd",
>> - .devname = "s5pv310-fb.0",
>> + .name = "lcd",
>> + .devname = "exynos4-fb.0",
>> .enable = exynos4_clk_ip_lcd0_ctrl,
>> .ctrlbit = (1<< 0),
>> }, {
>> - .name = "fimd",
>> - .devname = "s5pv310-fb.1",
>> + .name = "lcd",
>
> As I remember, some guys discussed about the clock name before.
>
> Please refer to the following diagram. Before EXYNOS4210 clk 'lcd' was used
> for FIMD IP core clock and source of the LCD pixel clock. But the mux used
> to select source of LCD pixel clock is removed. So 'lcd' clock is only used
> for core clock of FIMD IP. It isn't used for LCD pixel clock.
>
> As a result clock name was changed from lcd to fimd in the EXYNOS4210
> datasheet.
>
In drivers/video/s3c-fb.c:s3c_fb_probe(), the bus clock is assumed to be
'lcd'. The bus clock name in all other related machine folder is 'lcd'.
Hence for consistency, we might consider renaming 'fimd'=>'lcd', even
though the clock name is different in the datasheet.
--
Tushar Behera
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-30 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-20 22:54 [PATCH V8 1/5] ARM: EXYNOS4: Change clock name for FIMD Jingoo Han
2011-07-21 7:16 ` Kukjin Kim
2011-08-30 14:56 ` Tushar Behera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).