From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH 0/6] fbcon: Clean up glyph handling on redraws
Date: Tue, 17 Nov 2026 15:47:18 +0100 [thread overview]
Message-ID: <007f5717-148a-4c90-8352-1fe464bf77b6@suse.de> (raw)
In-Reply-To: <20261027133646.297856-1-tzimmermann@suse.de>
friendly ping for a review of this series
Am 27.10.26 um 14:27 schrieb Thomas Zimmermann:
> Fbcon's drawing functions open-code much of the glyph handling. Use
> font helpers instead. Makes fbcon more consistent and easier to
> understand.
>
> Patch 1 updates fbcon to use unsigned char for glyph buffers. This
> is consistent with the font code and font_data_t.
>
> Patches 2 and 3 update font rotation to return rotated glyphs as
> font_data_t. A rotated font can now use the same interfaces as the
> unrotated source font. Fbcon uses this to ref count the font buffer.
>
> Patches 4 to 6 update various parts of fbcon to use font helpers
> instead of open-coding access to font_data_t. Having the rotated
> font as font_data_t makes this convenient.
>
> Tested with fbcon on DRM's bochs driver (qemu).
>
> Thomas Zimmermann (6):
> fbcon: Use unsigned char for glyph data
> lib/fonts: Provide internal helpers for allocating font_data_t
> lib/fonts, fbcon: Use font_data_t for rotated fonts
> fbcon: Refactor size calculation for cursor buffers
> fbcon: Look up glyphs using the font interface
> fbcon: Handle characters with no glyph defined in a consistent way
>
> drivers/video/fbdev/core/bitblit.c | 82 +++++++++++++++----------
> drivers/video/fbdev/core/fbcon.c | 3 +-
> drivers/video/fbdev/core/fbcon.h | 5 +-
> drivers/video/fbdev/core/fbcon_ccw.c | 56 +++++++++++------
> drivers/video/fbdev/core/fbcon_cw.c | 57 ++++++++++-------
> drivers/video/fbdev/core/fbcon_rotate.c | 19 +++---
> drivers/video/fbdev/core/fbcon_ud.c | 77 +++++++++++++++--------
> include/linux/font.h | 5 +-
> lib/fonts/font.h | 12 ++++
> lib/fonts/font_rotate.c | 32 ++++------
> lib/fonts/fonts.c | 63 ++++++++++++-------
> 11 files changed, 254 insertions(+), 157 deletions(-)
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)
prev parent reply other threads:[~2026-11-17 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 13:27 [PATCH 0/6] fbcon: Clean up glyph handling on redraws Thomas Zimmermann
2026-10-27 13:27 ` [PATCH 1/6] fbcon: Use unsigned char for glyph data Thomas Zimmermann
2026-10-27 13:27 ` [PATCH 2/6] lib/fonts: Provide internal helpers for allocating font_data_t Thomas Zimmermann
2026-10-27 13:27 ` [PATCH 3/6] lib/fonts, fbcon: Use font_data_t for rotated fonts Thomas Zimmermann
2026-10-27 13:27 ` [PATCH 4/6] fbcon: Refactor size calculation for cursor buffers Thomas Zimmermann
2026-10-27 13:27 ` [PATCH 5/6] fbcon: Look up glyphs using the font interface Thomas Zimmermann
2026-10-27 13:27 ` [PATCH 6/6] fbcon: Handle characters with no glyph defined in a consistent way Thomas Zimmermann
2026-11-17 14:47 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=007f5717-148a-4c90-8352-1fe464bf77b6@suse.de \
--to=tzimmermann@suse.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox