Re: [PATCH 4/9] fbcon/fbdev: Add blanking notification

["Richard Purdie" <rpurdie@rpsys.net>]

Tony,

I've just switched to using this patch when I updated to 2.6.11-rc1 and I've 
noticed a problem. Basically my code which is monitoring FB_EVENT_BLANK 
events doesn't see any.

> diff -Nru a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> --- a/drivers/video/console/fbcon.c 2004-11-17 18:15:17 +08:00
> +++ b/drivers/video/console/fbcon.c 2004-12-21 05:55:41 +08:00
[...]
> + if (ops->blank_state != blank) {
> + if (info->fbops->fb_blank &&
> +     info->fbops->fb_blank(blank, info))
> + fbcon_generic_blank(vc, info, blank);
> +
> + ops->blank_state = blank;
> + }

I think this is the problem (in fbcon.c). Instead of calling 
info->fbops->fb_blank(blank, info)), I think this should call fb_blank(info, 
blank) (in fbmem.c) which can then make the fbops call itself.

If you agree, I'll send a patch (or you can patch it - I don't mind). Let me 
know...

Richard 



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt