* [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller.
@ 2011-01-05 10:34 Inki Dae
2011-03-17 8:23 ` Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Inki Dae @ 2011-01-05 10:34 UTC (permalink / raw)
To: linux-arm-kernel
the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2]
so it adds a clock object to clock framework for MIPI-DSI clock gating.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/mach-s5pv210/clock.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
index dab6ef3..a8d5235 100644
--- a/arch/arm/mach-s5pv210/clock.c
+++ b/arch/arm/mach-s5pv210/clock.c
@@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] = {
.enable = s5pv210_clk_ip1_ctrl,
.ctrlbit = (1<<0),
}, {
+ .name = "dsim",
+ .id = -1,
+ .parent = &clk_hclk_dsys.clk,
+ .enable = s5pv210_clk_ip1_ctrl,
+ .ctrlbit = (1<<2),
+ }, {
.name = "cfcon",
.id = 0,
.parent = &clk_hclk_psys.clk,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller.
2011-01-05 10:34 [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller Inki Dae
@ 2011-03-17 8:23 ` Kukjin Kim
2011-03-17 8:28 ` InKi Dae
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2011-03-17 8:23 UTC (permalink / raw)
To: linux-arm-kernel
Inki Dae wrote:
>
> the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2]
> so it adds a clock object to clock framework for MIPI-DSI clock gating.
>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/mach-s5pv210/clock.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
> index dab6ef3..a8d5235 100644
> --- a/arch/arm/mach-s5pv210/clock.c
> +++ b/arch/arm/mach-s5pv210/clock.c
> @@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] = {
> .enable = s5pv210_clk_ip1_ctrl,
> .ctrlbit = (1<<0),
> }, {
> + .name = "dsim",
> + .id = -1,
> + .parent = &clk_hclk_dsys.clk,
> + .enable = s5pv210_clk_ip1_ctrl,
> + .ctrlbit = (1<<2),
According to coding-style, should be added blank around "<<" like (1 << 2),
even though there are wrong things to others.
> + }, {
> .name = "cfcon",
> .id = 0,
> .parent = &clk_hclk_psys.clk,
> --
> 1.7.0.4
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller.
2011-03-17 8:23 ` Kukjin Kim
@ 2011-03-17 8:28 ` InKi Dae
0 siblings, 0 replies; 3+ messages in thread
From: InKi Dae @ 2011-03-17 8:28 UTC (permalink / raw)
To: linux-arm-kernel
2011/3/17 Kukjin Kim <kgene.kim@samsung.com>:
> Inki Dae wrote:
>>
>> the clock gate for MIPI-DSI controller is placed at CLK_GATE_IP1[2]
>> so it adds a clock object to clock framework for MIPI-DSI clock gating.
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/mach-s5pv210/clock.c | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
>> index dab6ef3..a8d5235 100644
>> --- a/arch/arm/mach-s5pv210/clock.c
>> +++ b/arch/arm/mach-s5pv210/clock.c
>> @@ -365,6 +365,12 @@ static struct clk init_clocks_disable[] = {
>> .enable = s5pv210_clk_ip1_ctrl,
>> .ctrlbit = (1<<0),
>> }, {
>> + .name = "dsim",
>> + .id = -1,
>> + .parent = &clk_hclk_dsys.clk,
>> + .enable = s5pv210_clk_ip1_ctrl,
>> + .ctrlbit = (1<<2),
>
> According to coding-style, should be added blank around "<<" like (1 << 2),
> even though there are wrong things to others.
>
ok, I will correct it and give me your comments on my second patch please.
thank you.
>> + }, {
>> .name = "cfcon",
>> .id = 0,
>> .parent = &clk_hclk_psys.clk,
>> --
>> 1.7.0.4
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-17 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-05 10:34 [PATCH 1/2] s5pc110: add clock gate for MIPI-DSI controller Inki Dae
2011-03-17 8:23 ` Kukjin Kim
2011-03-17 8:28 ` InKi Dae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).