From: "Richard Purdie" <rpurdie@rpsys.net>
To: linux-fbdev-devel@lists.sourceforge.net, kronos@people.it
Cc: adaplas@hotpop.com
Subject: Re: [patch] Add w100 framebuffer driver
Date: Sat, 8 Jan 2005 18:32:47 -0000 [thread overview]
Message-ID: <00c201c4f5b0$7689ad40$0f01a8c0@max> (raw)
In-Reply-To: 20050106180511.GA8050@dreamland.darkstar.lan
Kronos:
> Il Mon, Jan 03, 2005 at 07:47:33PM +0000, Richard Purdie ha scritto:
>> Add a framebuffer driver for the ATI w100 as found on several Sharp PDAs
>
> Some minor comments:
Thanks for the comments. I've made the suggested changes and will post an
updated patch shortly.
> Are you sure that the compiler does the right thing? Don't you need
> __attribute__((packed)) for this and the following structures?
It works without it but adding it doesn't hurt so I have. I've also killed
off all the typedefs as they hindered readability.
Cheers,
Richard
--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.300 / Virus Database: 265.6.9 - Release Date: 06/01/2005
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
prev parent reply other threads:[~2005-01-08 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 19:47 [patch] Add w100 framebuffer driver Richard Purdie
2005-01-04 9:31 ` Geert Uytterhoeven
2005-01-05 0:38 ` Richard Purdie
2005-01-06 18:05 ` Kronos
2005-01-08 18:32 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c201c4f5b0$7689ad40$0f01a8c0@max' \
--to=rpurdie@rpsys.net \
--cc=adaplas@hotpop.com \
--cc=kronos@people.it \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).