From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Date: Thu, 16 Aug 2012 10:39:57 +0000 Subject: RE: [PATCH v3 3/4] media: videobuf2-dma-contig: use dma_mmap_coherent if available Message-Id: <015b01cd7b9b$8010e2b0$8032a810$%szyprowski@samsung.com> List-Id: References: <1344246924-32620-1-git-send-email-hdk@igel.co.jp> <1344246924-32620-4-git-send-email-hdk@igel.co.jp> <012701cd74ac$6a617060$3f245120$%szyprowski@samsung.com> <20120816.191358.127675610.hdk@igel.co.jp> In-Reply-To: <20120816.191358.127675610.hdk@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Hideki EIRAKU' Cc: laurent.pinchart@ideasonboard.com, linux@arm.linux.org.uk, pawel@osciak.com, kyungmin.park@samsung.com, mchehab@infradead.org, FlorianSchandinat@gmx.de, perex@perex.cz, tiwai@suse.de, Tomasz Stanislawski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, matsu@igel.co.jp, dhobsong@igel.co.jp Hello, On Thursday, August 16, 2012 12:14 PM Hideki EIRAKU wrote: > From: Marek Szyprowski > Subject: RE: [PATCH v3 3/4] media: videobuf2-dma-contig: use dma_mmap_coherent if available > Date: Tue, 07 Aug 2012 16:53:25 +0200 > > > I'm sorry for bringing this issue now, once you have already created v3 of your > > patches, but similar patch has been already proposed some time ago. It is already > > processed together with general videobuf2-dma-contig redesign and dma-buf extensions > > by Tomasz Stanislawski. > > > > See post http://thread.gmane.org/gmane.comp.video.dri.devel/70402/focusI461 and > > http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/49438 > > > > It doesn't use conditional code inside videobuf2 allocator and rely entirely on > > dma-mapping subsystem to provide a working dma_mmap_coherent/writecombine/attrs() > > function. When it was posted, it relied on the dma-mapping extensions, which now > > have been finally merged to v3.6-rc1. Now I wonder if there are any architectures, > > which don't use dma_map_ops based dma-mapping framework, which might use > > videobuf2-dma-conting module. > > Thank you for telling me about videobuf2-dma-contig and v3.6-rc1. The > videobuf2-dma-contig patch I sent is now unnecessary. So I will > remove the patch. I will remove the patch defining > ARCH_HAS_DMA_MMAP_COHERENT too because the v3.6-rc1 kernel has generic > dma_mmap_coherent() API for every architecture. Just to let you know - Tomasz has posted an updated version of the dma-buf/vb2-dma-contig patches: http://www.spinics.net/lists/linux-media/msg51768.html Best regards -- Marek Szyprowski Samsung Poland R&D Center