From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Leela Krishna Amudala' <l.krishna@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
ben-linux@fluff.org, inki.dae@samsung.com, joshi@samsung.com,
jg1.han@samsung.com
Subject: RE: [PATCH 1/3] Move FIMD register headers to include/video/
Date: Wed, 01 Aug 2012 01:46:31 +0000 [thread overview]
Message-ID: <02e501cd6f87$79d9aff0$6d8d0fd0$%kim@samsung.com> (raw)
In-Reply-To: <1343637905-17764-2-git-send-email-l.krishna@samsung.com>
Leela Krishna Amudala wrote:
>
> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
> to include/video/samsung_fimd.h
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 -------
> arch/arm/plat-samsung/include/plat/regs-fb.h | 403 -----------------
> include/video/samsung_fimd.h | 533
+++++++++++++++++++++++
> 3 files changed, 533 insertions(+), 562 deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h
> create mode 100644 include/video/samsung_fimd.h
>
+ I have some comments on this.
[...]
> +/* VIDCON0 */
I don't think above comment is needed because everybody knows that from the
name of VIDCON0_.
> +
> +#define VIDCON0 (0x00)
> +#define VIDCON0_INTERLACE (1 << 29)
> +#define VIDCON0_VIDOUT_MASK (0x3 << 26)
> +#define VIDCON0_VIDOUT_SHIFT (26)
I think, you can use either of the following.
+#define VIDCON0_VIDOUT_SHIFT (26)
+#define VIDCON0_VIDOUT_MASK (0x3 <<
VIDCON0_VIDOUT_SHIFT)
Or just without XXX_SHIFT if the XXX_SHIFT is not used somewhere else,
+#define VIDCON0_VIDOUT_MASK (0x3 << 26)
[...]
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-08-01 1:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 8:57 [PATCH 0/3] ARM: SAMSUNG: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-07-30 8:57 ` [PATCH 1/3] Move FIMD register " Leela Krishna Amudala
2012-07-30 8:49 ` Sylwester Nawrocki
2012-07-30 11:17 ` Leela Krishna Amudala
2012-07-30 8:53 ` Jingoo Han
2012-07-30 9:09 ` Sylwester Nawrocki
2012-07-30 11:28 ` Leela Krishna Amudala
2012-07-30 14:32 ` Tomasz Figa
2012-07-31 0:47 ` Jingoo Han
2012-07-31 6:28 ` Marek Szyprowski
2012-07-31 7:24 ` Leela Krishna Amudala
2012-07-31 8:19 ` Jingoo Han
2012-07-31 8:32 ` Marek Szyprowski
2012-08-01 1:56 ` Kukjin Kim
2012-07-31 6:37 ` Tomasz Figa
2012-07-31 8:09 ` Jingoo Han
2012-08-01 1:50 ` Kukjin Kim
2012-08-01 1:46 ` Kukjin Kim [this message]
2012-07-30 8:57 ` [PATCH 2/3] arm: samsung: Include the modified FIMD header file Leela Krishna Amudala
2012-07-30 8:57 ` [PATCH 3/3] driver: " Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02e501cd6f87$79d9aff0$6d8d0fd0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).