From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kukjin Kim <kgene.kim@samsung.com>
Date: Wed, 01 Aug 2012 02:10:47 +0000
Subject: RE: [PATCH V2 1/5] include/video: Add samsung FIMD register header
Message-Id: <02f101cd6f8a$dd923910$98b6ab30$%kim@samsung.com>
List-Id: <linux-fbdev.vger.kernel.org>
References: <1343737385-23337-1-git-send-email-l.krishna@samsung.com>
 <1343737385-23337-2-git-send-email-l.krishna@samsung.com>
In-Reply-To: <1343737385-23337-2-git-send-email-l.krishna@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: 'Leela Krishna Amudala' <l.krishna@samsung.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, ben-linux@fluff.org, inki.dae@samsung.com, joshi@samsung.com, jg1.han@samsung.com, m.szyprowski@samsung.com

Leela Krishna Amudala wrote:
> 
> This patch copies the contents from regs-fb-v4.h and regs-fb.h to
> include/video/samsung_fimd.h
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  include/video/samsung_fimd.h |  526
> ++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 526 insertions(+), 0 deletions(-)
>  create mode 100644 include/video/samsung_fimd.h
> 
Firstly, please check my comment on your previous patches.

And I don't see following definitions are needed and used now. If some
definitions are not needed, they can be removed.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.