Re: w100 fb driver

["Richard Purdie" <rpurdie@rpsys.net>]

Antonino A. Daplas:
[re: inclusion of the w100 driver in the kernel]
> Should be okay, just wondering why not use the kernel i2c algo's instead
> of using your own.

The kernel's i2c algo's require two way communication and expect the data to
be ack'ed. In this case, we have no way to read the data back from the spp
interface so we can't implement all the functions the kernel interface would
need.

> Submit patch inline to this list and CC me.  Preferrably break the patch
> down into several, hopefully standalone patches.  Add a changelog, and a
> signed-off line.

That sounds fine. I've taken your comments (and those made by Geert 
Uytterhoeven) onboard and revised the driver. For various reasons, I've 
moved the driver over the to new device structure which allows me to pass a 
structure with some hardware specific details to the driver. This means I 
need to include the header file elsewhere in the kernel. Should/can I move 
that file to drivers/video in whole or in part (or do something else)?

An updated version of the driver is at:

http://www.rpsys.net/openzaurus/arm/w100-r1.patch

(its using two header files until I know which approach is preferred)

Thanks,

Richard 



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/