From: Hans de Goede <hdegoede@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linux-efi@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] efi/bgrt: Drop __initdata from bgrt_image_size
Date: Mon, 02 Jul 2018 11:26:04 +0000 [thread overview]
Message-ID: <0333a338-fc21-7f78-7785-f62a67f232a5@redhat.com> (raw)
In-Reply-To: <20180618151358.4830-1-hdegoede@redhat.com>
Bartlomiej,
Now that the fbcon deferred console takeover patches have been
merged I believe this series can be merged too ?
Note the first patch has an ack from Ard for merging the
1 line efi change through the fbdev tree.
Regards,
Hans
On 18-06-18 17:13, Hans de Goede wrote:
> bgrt_image_size is necessary to (optionally) show the boot graphics from
> the efifb code. The efifb driver is a platform driver, using a normal
> driver probe() driver callback. So even though it is always builtin it
> cannot reference __initdata.
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/firmware/efi/efi-bgrt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/efi-bgrt.c b/drivers/firmware/efi/efi-bgrt.c
> index 50793fda7819..b22ccfb0c991 100644
> --- a/drivers/firmware/efi/efi-bgrt.c
> +++ b/drivers/firmware/efi/efi-bgrt.c
> @@ -20,7 +20,7 @@
> #include <linux/efi-bgrt.h>
>
> struct acpi_table_bgrt bgrt_tab;
> -size_t __initdata bgrt_image_size;
> +size_t bgrt_image_size;
>
> struct bmp_header {
> u16 id;
>
next prev parent reply other threads:[~2018-07-02 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 15:13 [PATCH v2 1/2] efi/bgrt: Drop __initdata from bgrt_image_size Hans de Goede
2018-06-18 15:13 ` [PATCH v2 2/2] efifb: Copy the ACPI BGRT boot graphics to the framebuffer Hans de Goede
2018-07-02 11:26 ` Hans de Goede [this message]
2018-07-02 11:46 ` [PATCH v2 1/2] efi/bgrt: Drop __initdata from bgrt_image_size Ard Biesheuvel
2018-07-02 11:57 ` Bartlomiej Zolnierkiewicz
2018-07-02 12:02 ` Ard Biesheuvel
[not found] ` <CGME20180703152453eucas1p2b6fe0c9a8c8e0e7607a5d5bd8438f61e@eucas1p2.samsung.com>
2018-07-03 15:24 ` Bartlomiej Zolnierkiewicz
2018-07-03 15:25 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0333a338-fc21-7f78-7785-f62a67f232a5@redhat.com \
--to=hdegoede@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).