From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 820BAC433DB for ; Fri, 26 Feb 2021 16:39:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4179964F0D for ; Fri, 26 Feb 2021 16:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbhBZQjF (ORCPT ); Fri, 26 Feb 2021 11:39:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230014AbhBZQjC (ORCPT ); Fri, 26 Feb 2021 11:39:02 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 309C9C061574; Fri, 26 Feb 2021 08:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=cJovxi5fmivlMzTNFK7Hd5WeerVzqJFBxjTpoKstnCE=; b=XZPpJxh2rt+EtM7F9/8orkDvql c48+bn9P+Jx5tgPDS4YA2jYTdMgNUCFYmV5RMiQObH8/i0ZqpsYdVjBKY9gfk79xNxj4MwkTLjOv1 TtHkJePZ+d+Tzo8AR76MvgknBWL4+NMIifuapua/lzBY8/14zFcRXEidPhikakfSVICX92+ksNN8y BB0KL/7QxTEyx4+5q9XgBH0Avk7KlWqaqQVyQ7zGR5AEGO9/l2JOvk3PLVJ1Il9x1UM620k592pMk gOPQ27t1MMFBnZzjAguz92FFIR89l9ITBBBHnWhuaWSCHFdksr2vNCG5yDA9l+nbkuifjAMQXgvWX DL2rf+kw==; Received: from [2601:1c0:6280:3f0::3ba4] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFg80-0004FD-MQ; Fri, 26 Feb 2021 16:38:09 +0000 Subject: Re: [PATCH -next] fbdev: atyfb: use LCD management functions for PPC_PMAC also To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: linux-kernel@vger.kernel.org, Daniel Vetter , Nick Desaulniers , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Sam Ravnborg , David Airlie , Jani Nikula References: <20210226000537.8674-1-rdunlap@infradead.org> From: Randy Dunlap Message-ID: <03364ba0-8266-99e5-9315-34d8820e8732@infradead.org> Date: Fri, 26 Feb 2021 08:38:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 2/26/21 4:12 AM, Ville Syrjälä wrote: > On Thu, Feb 25, 2021 at 04:05:37PM -0800, Randy Dunlap wrote: >> Include PPC_PMAC in the configs that use aty_ld_lcd() and >> aty_st_lcd() implementations so that the PM code may work >> correctly for PPC_PMAC. >> >> Suggested-by: Ville Syrjälä >> Signed-off-by: Randy Dunlap >> Cc: Daniel Vetter >> Cc: Nick Desaulniers >> Cc: linux-fbdev@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: Bartlomiej Zolnierkiewicz >> Cc: Sam Ravnborg >> Cc: David Airlie >> Cc: Jani Nikula >> --- >> Daniel- We also need this patch: >> https://lore.kernel.org/dri-devel/20210224215528.822-1-rdunlap@infradead.org/ >> to fix a kernel test robot build error. >> >> drivers/video/fbdev/aty/atyfb_base.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> --- linux-next-20210219.orig/drivers/video/fbdev/aty/atyfb_base.c >> +++ linux-next-20210219/drivers/video/fbdev/aty/atyfb_base.c >> @@ -132,8 +132,7 @@ >> #define PRINTKI(fmt, args...) printk(KERN_INFO "atyfb: " fmt, ## args) >> #define PRINTKE(fmt, args...) printk(KERN_ERR "atyfb: " fmt, ## args) >> >> -#if defined(CONFIG_PMAC_BACKLIGHT) || defined(CONFIG_FB_ATY_GENERIC_LCD) || \ >> -defined(CONFIG_FB_ATY_BACKLIGHT) >> +#if defined(CONFIG_PPC_PMAC) > > Did you send an old version by accident? That's definitely > not what we want since it would break everything except PPC_PMAC. Yikes! Yes, thanks for catching that. I'll get the newer version out soon. >> static const u32 lt_lcd_regs[] = { >> CNFG_PANEL_LG, >> LCD_GEN_CNTL_LG, >> @@ -175,8 +174,7 @@ u32 aty_ld_lcd(int index, const struct a >> return aty_ld_le32(LCD_DATA, par); >> } >> } >> -#else /* defined(CONFIG_PMAC_BACKLIGHT) || defined(CONFIG_FB_ATY_BACKLIGHT) \ >> - defined(CONFIG_FB_ATY_GENERIC_LCD) */ >> +#else /* defined(CONFIG_PPC_PMAC) */ >> void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) >> { } >> >> @@ -184,7 +182,7 @@ u32 aty_ld_lcd(int index, const struct a >> { >> return 0; >> } >> -#endif /* defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) */ >> +#endif /* defined(CONFIG_PPC_PMAC) */ >> >> #ifdef CONFIG_FB_ATY_GENERIC_LCD >> /* > -- ~Randy