From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Leela Krishna Amudala' <l.krishna@samsung.com>,
'Sylwester Nawrocki' <s.nawrocki@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
ben-linux@fluff.org, inki.dae@samsung.com, joshi@samsung.com,
jg1.han@samsung.com, m.szyprowski@samsung.com
Subject: RE: [PATCH V2 5/5] arm: samsung: delete frame buffer header files from platform
Date: Wed, 01 Aug 2012 09:39:17 +0000 [thread overview]
Message-ID: <037101cd6fc9$85386e30$8fa94a90$%kim@samsung.com> (raw)
In-Reply-To: <CAL1wa8cShB7zDj-CPvfEncX+Up7enKM9MJOt-488dThj_tXbMA@mail.gmail.com>
Leela Krishna Amudala wrote:
>
> Hello Kgene,
>
> On Wed, Aug 1, 2012 at 7:34 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Leela Krishna Amudala wrote:
> >>
> >> The FIMD register headers are moved to include/video/
> >> hence, deleting these files from platform side
> >>
> >> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >> ---
> >> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 ---------
> >> arch/arm/plat-samsung/include/plat/regs-fb.h | 403
> > -------------------
> >> ----
> >> 2 files changed, 0 insertions(+), 562 deletions(-)
> >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h
> >>
> > No. This should be squashed into first patch on this series. See below.
> >
> > arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159
> > --------------------
> > .../plat/regs-fb.h => include/video/samsung_fimd.h | 145
> > ++++++++++++++++--
> > 2 files changed, 134 insertions(+), 170 deletions(-)
> > delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> > rename arch/arm/plat-samsung/include/plat/regs-fb.h =>
> > include/video/samsung_fimd.h (74%)
> >
>
> If I squash it with the first patch and if somebody set that as a head
> commit, it will break the build. Hence, splitted it up from the first
> patch.
>
NACK. your changes are not adding just moving. So should be squashed. If
required, you could create just one patch for moving them, probably, 1st,
3rd, 4th and 5th patches into one patch.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> Thank you Sylwester for suggesting this split up change.
>
> Regards,
> Leela Krishna
next prev parent reply other threads:[~2012-08-01 9:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 12:35 [PATCH V2 0/5] arm: samsung: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-07-31 12:35 ` [PATCH V2 1/5] include/video: Add samsung FIMD register header Leela Krishna Amudala
2012-08-01 2:10 ` Kukjin Kim
2012-07-31 12:35 ` [PATCH V2 2/5] include/video: Add Exynos5 specific FIMD register offsets Leela Krishna Amudala
2012-07-31 12:51 ` Sergei Shtylyov
2012-07-31 13:03 ` Sylwester Nawrocki
2012-08-01 1:49 ` Jingoo Han
2012-08-01 2:14 ` Kukjin Kim
2012-07-31 12:35 ` [PATCH V2 3/5] arm: samsung: Include the modified FIMD header file Leela Krishna Amudala
2012-08-01 1:42 ` Jingoo Han
2012-08-01 2:19 ` Kukjin Kim
2012-07-31 12:35 ` [PATCH V2 4/5] driver: " Leela Krishna Amudala
2012-08-01 1:36 ` Jingoo Han
2012-08-01 2:20 ` Kukjin Kim
2012-07-31 12:35 ` [PATCH V2 5/5] arm: samsung: delete frame buffer header files from platform Leela Krishna Amudala
2012-08-01 2:04 ` Kukjin Kim
2012-08-01 3:32 ` Leela Krishna Amudala
2012-08-01 9:39 ` Kukjin Kim [this message]
2012-08-01 10:00 ` Sylwester Nawrocki
2012-08-01 10:09 ` Kukjin Kim
2012-08-01 2:28 ` [PATCH V2 0/5] arm: samsung: Move FIMD headers to include/video/ Kukjin Kim
2012-08-01 9:59 ` Florian Tobias Schandinat
2012-08-01 10:03 ` Kukjin Kim
2012-08-23 9:55 ` Kukjin Kim
2012-09-23 19:26 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='037101cd6fc9$85386e30$8fa94a90$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).