From: kgunda@codeaurora.org
To: Pavel Machek <pavel@ucw.cz>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
bjorn.andersson@linaro.org, jingoohan1@gmail.com,
lee.jones@linaro.org, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, jacek.anaszewski@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral
Date: Mon, 23 Jul 2018 06:28:19 +0000 [thread overview]
Message-ID: <038029fded9ee724097685a3f0e8bdf9@codeaurora.org> (raw)
In-Reply-To: <20180720212128.GA13883@amd>
On 2018-07-21 02:51, Pavel Machek wrote:
> Hi!
>
>> >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx)
>> > }
>> > #define WLED3 3
>> >+#define WLED4 4
>>
>> Are these macros always going to define 3 to be 3 and 4 to be 4. If so
>> we
>> probably don't need them (and they should be removed from patch 5/8
>> too).
>>
>> There is a degree of nitpicking here however. The rest looks OK to me.
>
> Really nitpicking, and I don't care much either way, but as natural
> numbering would be 0-based, I'd keep the defines.
> Pavel
Thanks Pavale/Daniel! I will remove the macros and use the number 3 and
4 instead.
next prev parent reply other threads:[~2018-07-23 6:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1531131741-19971-1-git-send-email-kgunda@codeaurora.org>
2018-07-09 10:34 ` [PATCH V4 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-07-09 10:34 ` [PATCH V4 4/8] backlight: qcom-wled: Rename PM8941* to WLED3 Kiran Gunda
2018-07-20 13:23 ` Daniel Thompson
2018-07-23 5:55 ` kgunda
2018-08-07 5:41 ` Bjorn Andersson
2018-08-16 5:42 ` kgunda
2018-07-09 10:34 ` [PATCH V4 5/8] backlight: qcom-wled: Restructure the driver for WLED3 Kiran Gunda
2018-07-20 13:40 ` Daniel Thompson
2018-08-07 5:37 ` Bjorn Andersson
2018-08-16 5:40 ` kgunda
2018-07-09 10:34 ` [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-07-20 13:47 ` Daniel Thompson
2018-07-20 21:21 ` Pavel Machek
2018-07-23 6:28 ` kgunda [this message]
2018-08-07 5:45 ` Bjorn Andersson
2018-07-09 10:34 ` [PATCH V4 7/8] backlight: qcom-wled: add support for short circuit handling Kiran Gunda
2018-07-20 14:07 ` Daniel Thompson
2018-07-23 6:17 ` kgunda
2018-07-09 10:34 ` [PATCH V4 8/8] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-08-07 6:32 ` Bjorn Andersson
2018-08-16 5:45 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=038029fded9ee724097685a3f0e8bdf9@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).