From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Date: Mon, 09 Jul 2018 05:12:50 +0000 Subject: Re: [PATCH 1/4] video: fbdev: pxafb: clear allocated memory for video modes Message-Id: <0403832b-545a-be1d-a0e8-fee4f4177578@zonque.org> List-Id: References: <20180624153817.24387-1-daniel@zonque.org> In-Reply-To: <20180624153817.24387-1-daniel@zonque.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-fbdev@vger.kernel.org Hi Bartlomiej, Should I resend with Robert's Reviewed-bys again? I'd like to get this merged for 4.19 if possible. Thanks, Daniel On Sunday, June 24, 2018 05:38 PM, Daniel Mack wrote: > When parsing the video modes from DT properties, make sure to zero out > memory before using it. This is important because not all fields in the mode > struct are explicitly initialized, even though they are used later on. > > Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion) > Reviewed-by: Robert Jarzmik > Signed-off-by: Daniel Mack > --- > drivers/video/fbdev/pxafb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c > index 76722a59f55e..dfe382e68287 100644 > --- a/drivers/video/fbdev/pxafb.c > +++ b/drivers/video/fbdev/pxafb.c > @@ -2128,8 +2128,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, > return -EINVAL; > > ret = -ENOMEM; > - info->modes = kmalloc_array(timings->num_timings, > - sizeof(info->modes[0]), GFP_KERNEL); > + info->modes = kcalloc(timings->num_timings, sizeof(info->modes[0]), > + GFP_KERNEL); > if (!info->modes) > goto out; > info->num_modes = timings->num_timings; >