* pm3fb.c: question
@ 2020-03-14 7:35 Randy Dunlap
2020-03-14 17:41 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-03-14 7:35 UTC (permalink / raw)
To: linux-fbdev
In drivers/video/fbdev/pm3fb.c, if I change the definition of DPRINTK()
(in order to remove some gcc warnings if -Wextra is used), like this:
-#define DPRINTK(a, b...)
+#define DPRINTK(a, b...) no_printk(a, ##b)
I get a build error here:
default:
DPRINTK("Unsupported depth %d\n",
info->current_par->depth);
break;
../drivers/video/fbdev/pm3fb.c: In function ‘pm3fb_init_engine’:
../drivers/video/fbdev/pm3fb.c:353:9: error: ‘struct fb_info’ has no member named ‘current_par’
info->current_par->depth);
^
Is there a replacement (fix) for this field?
or should the entire DPRINTK() be deleted?
or somethine else?
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: pm3fb.c: question
2020-03-14 7:35 pm3fb.c: question Randy Dunlap
@ 2020-03-14 17:41 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2020-03-14 17:41 UTC (permalink / raw)
To: linux-fbdev
On 3/14/20 12:35 AM, Randy Dunlap wrote:
> In drivers/video/fbdev/pm3fb.c, if I change the definition of DPRINTK()
> (in order to remove some gcc warnings if -Wextra is used), like this:
>
> -#define DPRINTK(a, b...)
> +#define DPRINTK(a, b...) no_printk(a, ##b)
>
> I get a build error here:
> default:
> DPRINTK("Unsupported depth %d\n",
> info->current_par->depth);
> break;
>
> ../drivers/video/fbdev/pm3fb.c: In function ‘pm3fb_init_engine’:
> ../drivers/video/fbdev/pm3fb.c:353:9: error: ‘struct fb_info’ has no member named ‘current_par’
> info->current_par->depth);
> ^
>
> Is there a replacement (fix) for this field?
> or should the entire DPRINTK() be deleted?
> or somethine else?
Got it.
I'll just change it to what is used in the switch statement above.
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-14 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-14 7:35 pm3fb.c: question Randy Dunlap
2020-03-14 17:41 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).