From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ECB22101A0; Thu, 12 Dec 2024 18:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734029064; cv=none; b=SdKUf7GEDJ0ods3sXEg+YqEKkul4939+CSHRlk7PPpOfPXo09oL5j31jjGY+Q5bLN9XkFNhXYOAkJlxNw8+g6w0I0t4YiBbNSmV4M9bERWekyuRi7Q5fGkBSUynhV+4EjtUu+h5PBwrtLJ0ADAe1ZNDfQg/cQxpR8Kn/gOGXMIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734029064; c=relaxed/simple; bh=S4Rd56OXPKKBqh6QcGoxX9/LtJ4epaodG91YqKaLFCs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HGUZ2L7OZ0IXFAJj94a7YJ4+lQtdQg+LrXj8LG8kGnW1ccwGndLCU5uelVTw9STVp0n9waIw0feA9sMUSeEnGjgLznz30aGKKukRfCktszJ4vB+DylHaLkMYWeS7kuBQaoGrMork0UvcuzJ5R5oPceTYKrgUd5yN25LuBcAMcJY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=deller@gmx.de header.b=i6BxWgbC; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=deller@gmx.de header.b="i6BxWgbC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1734029049; x=1734633849; i=deller@gmx.de; bh=6TXE7mLQXOgxwGFrrzwFYmcp5ur8m9Zy+/eKsJ5JmhE=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=i6BxWgbC5kj6T79fzlMoor5OeNe22f5wFFssCDiVTJSocXrUZ2vZUMghz3v4t/as A6G+ZLFEdiN1e+DYjccpjZ2UdJe6VmN69gWQlnL+UBo3y+efFw8aPpSAhSlOC2wia PBMRzYvvEgHHsgCpQ/HFjXVBDPkfFez2YJ5RknvONNI1zYCRJAsJCksHz1wdz8WJK r6ZO8SnRQFiuEbcqs1ybuPlJbNJtNiZ57KIz/vpdtuGLdzBJckPl/0x0EIsjeUJX/ UkW8VJCoHnwwKVSKzPw8oZ5fpO+4R78ivxqYpryQ9aK/YmuwowE6BpeDZS4zPQ9le 59j8rYRBGgSlS/QYhw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.172] ([109.250.63.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXXuH-1t6imM22hT-00LRdw; Thu, 12 Dec 2024 19:44:09 +0100 Message-ID: <09edb59a-527a-4ddb-bfaf-ea74fb5a3023@gmx.de> Date: Thu, 12 Dec 2024 19:44:08 +0100 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE To: Thomas Zimmermann , javierm@redhat.com, arnd@arndb.de, simona@ffwll.ch, airlied@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org References: <20241212100636.45875-1-tzimmermann@suse.de> <20241212100636.45875-2-tzimmermann@suse.de> Content-Language: en-US From: Helge Deller Autocrypt: addr=deller@gmx.de; keydata= xsFNBF3Ia3MBEAD3nmWzMgQByYAWnb9cNqspnkb2GLVKzhoH2QD4eRpyDLA/3smlClbeKkWT HLnjgkbPFDmcmCz5V0Wv1mKYRClAHPCIBIJgyICqqUZo2qGmKstUx3pFAiztlXBANpRECgwJ r+8w6mkccOM9GhoPU0vMaD/UVJcJQzvrxVHO8EHS36aUkjKd6cOpdVbCt3qx8cEhCmaFEO6u CL+k5AZQoABbFQEBocZE1/lSYzaHkcHrjn4cQjc3CffXnUVYwlo8EYOtAHgMDC39s9a7S90L 69l6G73lYBD/Br5lnDPlG6dKfGFZZpQ1h8/x+Qz366Ojfq9MuuRJg7ZQpe6foiOtqwKym/zV dVvSdOOc5sHSpfwu5+BVAAyBd6hw4NddlAQUjHSRs3zJ9OfrEx2d3mIfXZ7+pMhZ7qX0Axlq Lq+B5cfLpzkPAgKn11tfXFxP+hcPHIts0bnDz4EEp+HraW+oRCH2m57Y9zhcJTOJaLw4YpTY GRUlF076vZ2Hz/xMEvIJddRGId7UXZgH9a32NDf+BUjWEZvFt1wFSW1r7zb7oGCwZMy2LI/G aHQv/N0NeFMd28z+deyxd0k1CGefHJuJcOJDVtcE1rGQ43aDhWSpXvXKDj42vFD2We6uIo9D 1VNre2+uAxFzqqf026H6cH8hin9Vnx7p3uq3Dka/Y/qmRFnKVQARAQABzRxIZWxnZSBEZWxs ZXIgPGRlbGxlckBnbXguZGU+wsGRBBMBCAA7AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEERUSCKCzZENvvPSX4Pl89BKeiRgMFAl3J1zsCGQEACgkQPl89BKeiRgNK7xAAg6kJTPje uBm9PJTUxXaoaLJFXbYdSPfXhqX/BI9Xi2VzhwC2nSmizdFbeobQBTtRIz5LPhjk95t11q0s uP5htzNISPpwxiYZGKrNnXfcPlziI2bUtlz4ke34cLK6MIl1kbS0/kJBxhiXyvyTWk2JmkMi REjR84lCMAoJd1OM9XGFOg94BT5aLlEKFcld9qj7B4UFpma8RbRUpUWdo0omAEgrnhaKJwV8 qt0ULaF/kyP5qbI8iA2PAvIjq73dA4LNKdMFPG7Rw8yITQ1Vi0DlDgDT2RLvKxEQC0o3C6O4 iQq7qamsThLK0JSDRdLDnq6Phv+Yahd7sDMYuk3gIdoyczRkXzncWAYq7XTWl7nZYBVXG1D8 gkdclsnHzEKpTQIzn/rGyZshsjL4pxVUIpw/vdfx8oNRLKj7iduf11g2kFP71e9v2PP94ik3 Xi9oszP+fP770J0B8QM8w745BrcQm41SsILjArK+5mMHrYhM4ZFN7aipK3UXDNs3vjN+t0zi qErzlrxXtsX4J6nqjs/mF9frVkpv7OTAzj7pjFHv0Bu8pRm4AyW6Y5/H6jOup6nkJdP/AFDu 5ImdlA0jhr3iLk9s9WnjBUHyMYu+HD7qR3yhX6uWxg2oB2FWVMRLXbPEt2hRGq09rVQS7DBy dbZgPwou7pD8MTfQhGmDJFKm2jvOwU0EXchrcwEQAOsDQjdtPeaRt8EP2pc8tG+g9eiiX9Sh rX87SLSeKF6uHpEJ3VbhafIU6A7hy7RcIJnQz0hEUdXjH774B8YD3JKnAtfAyuIU2/rOGa/v UN4BY6U6TVIOv9piVQByBthGQh4YHhePSKtPzK9Pv/6rd8H3IWnJK/dXiUDQllkedrENXrZp eLUjhyp94ooo9XqRl44YqlsrSUh+BzW7wqwfmu26UjmAzIZYVCPCq5IjD96QrhLf6naY6En3 ++tqCAWPkqKvWfRdXPOz4GK08uhcBp3jZHTVkcbo5qahVpv8Y8mzOvSIAxnIjb+cklVxjyY9 dVlrhfKiK5L+zA2fWUreVBqLs1SjfHm5OGuQ2qqzVcMYJGH/uisJn22VXB1c48yYyGv2HUN5 lC1JHQUV9734I5cczA2Gfo27nTHy3zANj4hy+s/q1adzvn7hMokU7OehwKrNXafFfwWVK3OG 1dSjWtgIv5KJi1XZk5TV6JlPZSqj4D8pUwIx3KSp0cD7xTEZATRfc47Yc+cyKcXG034tNEAc xZNTR1kMi9njdxc1wzM9T6pspTtA0vuD3ee94Dg+nDrH1As24uwfFLguiILPzpl0kLaPYYgB wumlL2nGcB6RVRRFMiAS5uOTEk+sJ/tRiQwO3K8vmaECaNJRfJC7weH+jww1Dzo0f1TP6rUa fTBRABEBAAHCwXYEGAEIACAWIQRFRIIoLNkQ2+89Jfg+Xz0Ep6JGAwUCXchrcwIbDAAKCRA+ Xz0Ep6JGAxtdEAC54NQMBwjUNqBNCMsh6WrwQwbg9tkJw718QHPw43gKFSxFIYzdBzD/YMPH l+2fFiefvmI4uNDjlyCITGSM+T6b8cA7YAKvZhzJyJSS7pRzsIKGjhk7zADL1+PJei9p9idy RbmFKo0dAL+ac0t/EZULHGPuIiavWLgwYLVoUEBwz86ZtEtVmDmEsj8ryWw75ZIarNDhV74s BdM2ffUJk3+vWe25BPcJiaZkTuFt+xt2CdbvpZv3IPrEkp9GAKof2hHdFCRKMtgxBo8Kao6p Ws/Vv68FusAi94ySuZT3fp1xGWWf5+1jX4ylC//w0Rj85QihTpA2MylORUNFvH0MRJx4mlFk XN6G+5jIIJhG46LUucQ28+VyEDNcGL3tarnkw8ngEhAbnvMJ2RTx8vGh7PssKaGzAUmNNZiG MB4mPKqvDZ02j1wp7vthQcOEg08z1+XHXb8ZZKST7yTVa5P89JymGE8CBGdQaAXnqYK3/yWf FwRDcGV6nxanxZGKEkSHHOm8jHwvQWvPP73pvuPBEPtKGLzbgd7OOcGZWtq2hNC6cRtsRdDx 4TAGMCz4j238m+2mdbdhRh3iBnWT5yPFfnv/2IjFAk+sdix1Mrr+LIDF++kiekeq0yUpDdc4 ExBy2xf6dd+tuFFBp3/VDN4U0UfG4QJ2fg19zE5Z8dS4jGIbLg== In-Reply-To: <20241212100636.45875-2-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:O8E7+o+kv6KBXQtXCkoW4cH+RgC1Sptb8yQAVZhoLrDm0zoCMvG yVz2S5Jg1/ADBWVbcbY4YTh0/bbjrqdRUvU0oEfNhDIw+n5R7zsYMQCH7DHiAw6yRgONlJC 3qfY2hX3QXHgBKuq9YbnMkrnK54wQB//SphMiH+m1ft44BhCs6UXIK3IloqbbzMaoQLMN6Q lVERJ2bRwFrwnwm9rCSXg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:KgtEgJeGDAQ=;WPGZQIxD4LVwgkwOivijqUBL0Q/ ufCAqmqCnihN4JM3XmWqal02zzuZ6AF6KcGv3Va0HajOpUYrsTY7T4NQBeEJsSkxdZkFUAEqM G1slDM2U5Gb4i7mT02ilbGbmRiZNA+6bp+IfGBDdfguoyZ1RxVaIe29Er/N7Jo+/iZGz2kgKf sWraxfvUVpRKObq0XhrujbUVorGC+ievL+1GZR88vdYobxPxG3TItl87jHUdXYKw/SwqUhR8O Lk8W/+Dz3srTdLfOTiNGy7AMMor0SJ/G2h5TcvNxzFO0d0sU1R0nXhwUHTeoe3b+9IELgSERC yYcPBbXNn4903InZRyXnECMe9jqEdPpZqeHb4HskNnGu0naygSIyjeO7rPSOKlszdttOY38YU a2Kbs0nuSjmoE4EkjP9FYCryd2/ZiJzOlHZyYruJ1scDwjP0WYAq+Pa9NRNIha821lxTP7GyD nHD60lGxBtVVudXIQYP/MhIEcsmXzszSNQIMyFro+CF1Anbcztr2PNPeu1MvhN/ISW9yly27r rETZ1dDs18v3qQDVai9HM3wA/hmrb8bAZ2SpMAqoZgNDC36xCoat0xb+kKLUDG0uoEaDjcfhP s92QknaHuZVmncn33CTvZrMuRw9W/UbEYL5707x3lyZMxHg6v63eY4phorxW47ZbqnVFEaI6D Q9SFvJ5stgX13afmqC9jfwJcQpknPDEZuubkcfrdzxMIVYF+OVn0MGd+GClw5MAKMoTkn2cE+ aB49/4MInPHSztxny6sNdi0B4kst6dN37m69V4uzRwqtGAq/+w6EhqseOndyYbI6LOHfcsn+e ZM37XCuZ2Q0kidhkXtruFvbctdGU/JFSs93JGDoO2sxcZBGjgUhnOAZZ0BYIjJvcJf7xdHuL9 VLat3qO7XY3B+AvhxupiI70Q7DjIoRP/xePmJ37fVjjp/bE/U/yhzo4GFaTT5O/SOpzrr5KYz w6zzWVZi3XNNeMiCjpe2TyzYzVdEzoE06V8F57yma4fvtxUzKwJ3dO4d7Qe7+6TGg17ctZTTX Z9oLRhwUqvNhoEED07KZv65VU+mu3tw/WYHsJjsOTF/zyUTAT5LgAInFV9mTN75tSIslf9CLK whe9sQg9qRfbFfICHvSSCJS3xQLtKv On 12/12/24 11:04, Thomas Zimmermann wrote: > Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter > only controls backlight support within fbdev core code and data > structures. > > Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users > select it explicitly. Fixes warnings about recursive dependencies, > such as [...] I think in the fbdev drivers themselves you should do: select BACKLIGHT_CLASS_DEVICE instead of "depending" on it. This is the way as it's done in the DRM tiny and the i915/gma500 DRM drive= rs. So, something like: =2D-- a/drivers/staging/fbtft/Kconfig tristate "Support for small TFT LCD display modules" depends on FB && SPI depends on FB_DEVICE + select BACKLIGHT_DEVICE_CLASS depends on GPIOLIB || COMPILE_TEST select FB_BACKLIGHT config FB_BACKLIGHT tristate depends on FB - select BACKLIGHT_CLASS_DEVICE + depends on BACKLIGHT_CLASS_DEVICE Would that fix the dependency warning? Helge > > error: recursive dependency detected! > symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHT > symbol FB_BACKLIGHT is selected by FB_SH_MOBILE_LCDC > symbol FB_SH_MOBILE_LCDC depends on FB_DEVICE > symbol FB_DEVICE depends on FB_CORE > symbol FB_CORE is selected by DRM_GEM_DMA_HELPER > symbol DRM_GEM_DMA_HELPER is selected by DRM_PANEL_ILITEK_ILI9341 > symbol DRM_PANEL_ILITEK_ILI9341 depends on BACKLIGHT_CLASS_DEVICE > > BACKLIGHT_CLASS_DEVICE is user-selectable, so making drivers adapt to > it is the correct approach in any case. For most drivers, backlight > support is also configurable separately. > > v2: > - s/BACKLIGHT_DEVICE_CLASS/BACKLIGHT_CLASS_DEVICE (Helge) > - Fix fbdev driver-dependency corner case (Arnd) > > Signed-off-by: Thomas Zimmermann > --- > drivers/auxdisplay/Kconfig | 2 +- > drivers/macintosh/Kconfig | 1 + > drivers/staging/fbtft/Kconfig | 1 + > drivers/video/fbdev/Kconfig | 18 +++++++++++++----- > drivers/video/fbdev/core/Kconfig | 3 +-- > 5 files changed, 17 insertions(+), 8 deletions(-) > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 21545ffba065..8934e6ad5772 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -489,7 +489,7 @@ config IMG_ASCII_LCD > > config HT16K33 > tristate "Holtek Ht16K33 LED controller with keyscan" > - depends on FB && I2C && INPUT > + depends on FB && I2C && INPUT && BACKLIGHT_CLASS_DEVICE > select FB_SYSMEM_HELPERS > select INPUT_MATRIXKMAP > select FB_BACKLIGHT > diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig > index fb38f684444f..bf3824032d61 100644 > --- a/drivers/macintosh/Kconfig > +++ b/drivers/macintosh/Kconfig > @@ -120,6 +120,7 @@ config PMAC_MEDIABAY > config PMAC_BACKLIGHT > bool "Backlight control for LCD screens" > depends on PPC_PMAC && ADB_PMU && FB =3D y && (BROKEN || !PPC64) > + depends on BACKLIGHT_CLASS_DEVICE > select FB_BACKLIGHT > help > Say Y here to enable Macintosh specific extensions of the generic > diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconf= ig > index 77ab44362f16..dcf6a70455cc 100644 > --- a/drivers/staging/fbtft/Kconfig > +++ b/drivers/staging/fbtft/Kconfig > @@ -3,6 +3,7 @@ menuconfig FB_TFT > tristate "Support for small TFT LCD display modules" > depends on FB && SPI > depends on FB_DEVICE > + depends on BACKLIGHT_CLASS_DEVICE > depends on GPIOLIB || COMPILE_TEST > select FB_BACKLIGHT > select FB_SYSMEM_HELPERS_DEFERRED > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index de035071fedb..55c6686f091e 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -649,6 +649,7 @@ config FB_S1D13XXX > config FB_ATMEL > tristate "AT91 LCD Controller support" > depends on FB && OF && HAVE_CLK && HAS_IOMEM > + depends on BACKLIGHT_CLASS_DEVICE > depends on HAVE_FB_ATMEL || COMPILE_TEST > select FB_BACKLIGHT > select FB_IOMEM_HELPERS > @@ -660,7 +661,6 @@ config FB_ATMEL > config FB_NVIDIA > tristate "nVidia Framebuffer Support" > depends on FB && PCI > - select FB_BACKLIGHT if FB_NVIDIA_BACKLIGHT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -700,6 +700,8 @@ config FB_NVIDIA_DEBUG > config FB_NVIDIA_BACKLIGHT > bool "Support for backlight control" > depends on FB_NVIDIA > + depends on BACKLIGHT_CLASS_DEVICE=3Dy || BACKLIGHT_CLASS_DEVICE=3DFB_N= VIDIA > + select FB_BACKLIGHT > default y > help > Say Y here if you want to control the backlight of your display. > @@ -707,7 +709,6 @@ config FB_NVIDIA_BACKLIGHT > config FB_RIVA > tristate "nVidia Riva support" > depends on FB && PCI > - select FB_BACKLIGHT if FB_RIVA_BACKLIGHT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -747,6 +748,8 @@ config FB_RIVA_DEBUG > config FB_RIVA_BACKLIGHT > bool "Support for backlight control" > depends on FB_RIVA > + depends on BACKLIGHT_CLASS_DEVICE=3Dy || BACKLIGHT_CLASS_DEVICE=3DFB_R= IVA > + select FB_BACKLIGHT > default y > help > Say Y here if you want to control the backlight of your display. > @@ -934,7 +937,6 @@ config FB_MATROX_MAVEN > config FB_RADEON > tristate "ATI Radeon display support" > depends on FB && PCI > - select FB_BACKLIGHT if FB_RADEON_BACKLIGHT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -960,6 +962,8 @@ config FB_RADEON_I2C > config FB_RADEON_BACKLIGHT > bool "Support for backlight control" > depends on FB_RADEON > + depends on BACKLIGHT_CLASS_DEVICE=3Dy || BACKLIGHT_CLASS_DEVICE=3DFB_R= ADEON > + select FB_BACKLIGHT > default y > help > Say Y here if you want to control the backlight of your display. > @@ -975,7 +979,6 @@ config FB_RADEON_DEBUG > config FB_ATY128 > tristate "ATI Rage128 display support" > depends on FB && PCI > - select FB_BACKLIGHT if FB_ATY128_BACKLIGHT > select FB_IOMEM_HELPERS > select FB_MACMODES if PPC_PMAC > help > @@ -989,6 +992,8 @@ config FB_ATY128 > config FB_ATY128_BACKLIGHT > bool "Support for backlight control" > depends on FB_ATY128 > + depends on BACKLIGHT_CLASS_DEVICE=3Dy || BACKLIGHT_CLASS_DEVICE=3DFB_A= TY128 > + select FB_BACKLIGHT > default y > help > Say Y here if you want to control the backlight of your display. > @@ -999,7 +1004,6 @@ config FB_ATY > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > - select FB_BACKLIGHT if FB_ATY_BACKLIGHT > select FB_IOMEM_FOPS > select FB_MACMODES if PPC > select FB_ATY_CT if SPARC64 && PCI > @@ -1040,6 +1044,8 @@ config FB_ATY_GX > config FB_ATY_BACKLIGHT > bool "Support for backlight control" > depends on FB_ATY > + depends on BACKLIGHT_CLASS_DEVICE=3Dy || BACKLIGHT_CLASS_DEVICE=3DFB_A= TY > + select FB_BACKLIGHT > default y > help > Say Y here if you want to control the backlight of your display. > @@ -1528,6 +1534,7 @@ config FB_SH_MOBILE_LCDC > depends on FB && HAVE_CLK && HAS_IOMEM > depends on SUPERH || COMPILE_TEST > depends on FB_DEVICE > + depends on BACKLIGHT_CLASS_DEVICE > select FB_BACKLIGHT > select FB_DEFERRED_IO > select FB_DMAMEM_HELPERS > @@ -1793,6 +1800,7 @@ config FB_SSD1307 > tristate "Solomon SSD1307 framebuffer support" > depends on FB && I2C > depends on GPIOLIB || COMPILE_TEST > + depends on BACKLIGHT_CLASS_DEVICE > select FB_BACKLIGHT > select FB_SYSMEM_HELPERS_DEFERRED > help > diff --git a/drivers/video/fbdev/core/Kconfig b/drivers/video/fbdev/core= /Kconfig > index 0ab8848ba2f1..d554d8c543d4 100644 > --- a/drivers/video/fbdev/core/Kconfig > +++ b/drivers/video/fbdev/core/Kconfig > @@ -183,9 +183,8 @@ config FB_SYSMEM_HELPERS_DEFERRED > select FB_SYSMEM_HELPERS > > config FB_BACKLIGHT > - tristate > + bool > depends on FB > - select BACKLIGHT_CLASS_DEVICE > > config FB_MODE_HELPERS > bool "Enable Video Mode Handling Helpers"