From: Markus Elfring <Markus.Elfring@web.de>
To: yuebingkun@kylinos.cn, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, Helge Deller <deller@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] fbdev: platinumfb: add error checking for ioremap calls
Date: Mon, 17 Aug 2026 09:00:51 +0200 [thread overview]
Message-ID: <0acf67ac-3a86-44a1-8c1b-cf1462057da9@web.de> (raw)
In-Reply-To: <20260817063942.308926-1-yuebingkun@kylinos.cn>
…
> Add proper error checking and use goto-based cleanup to avoid code
> duplication across the error paths.
* Please avoid duplicate source code also in the implementation of the function “platinumfb_probe”
a bit more.
https://elixir.bootlin.com/linux/v7.2-rc7/source/drivers/video/fbdev/platinumfb.c#L527-L634
* Under which circumstances will development interests grow for the application of scope-based resource management?
…
> ---
> drivers/video/fbdev/platinumfb.c | 36 ++++++++++++++++++++++++++------
…
Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc7#n310
Regards,
Markus
prev parent reply other threads:[~2026-08-17 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 6:39 [PATCH v2] fbdev: platinumfb: add error checking for ioremap calls yuebingkun
2026-08-17 7:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0acf67ac-3a86-44a1-8c1b-cf1462057da9@web.de \
--to=markus.elfring@web.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuebingkun@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox