From: Javier Martinez Canillas <javierm@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>, Jerry Lin <wahahab11@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laszlo Ersek <lersek@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
kvm@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>,
kernel test robot <lkp@intel.com>,
Jens Frederich <jfrederich@gmail.com>,
Jon Nettleton <jon.nettleton@gmail.com>,
linux-staging@lists.linux.dev,
Daniel Vetter <daniel.vetter@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, Helge Deller <deller@gmx.de>,
Matthew Wilcox <willy@infradead.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Zhen Lei <thunder.leizhen@huawei.com>,
Alex Deucher <alexander.deucher@amd.com>,
Xiyu Yang <xiyuyang19@fudan.edu.cn>,
linux-fbdev@vger.kernel.org, Zheyu Ma <zheyuma97@gmail.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: Mark olpc_dcon BROKEN [Was: [PATCH v6 5/5] fbdev: Make registered_fb[] private to fbmem.c]
Date: Thu, 9 Jun 2022 19:38:39 +0200 [thread overview]
Message-ID: <0bdbec1f-196b-b82e-9d64-06029e250983@redhat.com> (raw)
In-Reply-To: <YqIskEjUvJo4y4cb@ravnborg.org>
Hello Sam,
On 6/9/22 19:23, Sam Ravnborg wrote:
[snip]
>
> To repeat myself from irc.
> olpc_dcon is a staging driver and we should avoid inventing anything in
> core code for to make staging drivers works.
> Geert suggested EXPORT_SYMPBOL_NS_GPL() that could work and narrow it
> down to olpc_dcon.
> The better approach is to mark said driver BROKEN and then someone can
> fix it it there is anyone who cares.
> Last commit to olpc_dcon was in 2019: e40219d5e4b2177bfd4d885e7b64e3b236af40ac
> and maybe Jerry Lin cares enough to fix it.
>
> Added Jerry and Greg to the mail.
>
> Sam
>
That does sound like the best approach indeed. And if the driver is kept
BROKEN for a few releases then it can just remove it from the kernel. If
someone still uses/cares about the driver, they can fix it as you said,
and it could even be ported to DRM if is something that's still useful.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-06-09 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 18:23 [PATCH v6 0/5] Fix some races between sysfb device registration and drivers probe Javier Martinez Canillas
2022-06-07 18:23 ` [PATCH v6 3/5] fbdev: Disable sysfb device registration when removing conflicting FBs Javier Martinez Canillas
2022-06-16 19:29 ` Zack Rusin
2022-06-16 19:55 ` Javier Martinez Canillas
2022-06-16 21:03 ` Zack Rusin
2022-06-16 22:18 ` Javier Martinez Canillas
2022-06-16 23:21 ` Javier Martinez Canillas
2022-06-17 1:35 ` Zack Rusin
2022-06-17 6:46 ` Javier Martinez Canillas
2022-07-04 9:36 ` Xi Ruoyao
2022-07-04 10:29 ` Xi Ruoyao
2022-07-04 11:04 ` Javier Martinez Canillas
2022-07-04 12:11 ` Xi Ruoyao
2022-07-04 12:22 ` Javier Martinez Canillas
2022-07-04 12:22 ` Thomas Zimmermann
2022-06-07 18:23 ` [PATCH v6 4/5] Revert "fbdev: Prevent probing generic drivers if a FB is already registered" Javier Martinez Canillas
2022-06-07 18:23 ` [PATCH v6 5/5] fbdev: Make registered_fb[] private to fbmem.c Javier Martinez Canillas
2022-06-09 11:49 ` Thomas Zimmermann
2022-06-09 13:09 ` Javier Martinez Canillas
2022-06-09 17:23 ` Mark olpc_dcon BROKEN [Was: [PATCH v6 5/5] fbdev: Make registered_fb[] private to fbmem.c] Sam Ravnborg
2022-06-09 17:38 ` Javier Martinez Canillas [this message]
2022-06-09 14:28 ` [PATCH v6 0/5] Fix some races between sysfb device registration and drivers probe Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bdbec1f-196b-b82e-9d64-06029e250983@redhat.com \
--to=javierm@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jfrederich@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sam@ravnborg.org \
--cc=thunder.leizhen@huawei.com \
--cc=tzimmermann@suse.de \
--cc=wahahab11@gmail.com \
--cc=willy@infradead.org \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).