From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BFCC43334 for ; Thu, 9 Jun 2022 17:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239202AbiFIRis (ORCPT ); Thu, 9 Jun 2022 13:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237756AbiFIRis (ORCPT ); Thu, 9 Jun 2022 13:38:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 88B3F563B8 for ; Thu, 9 Jun 2022 10:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654796324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k6TtggULp7/GiOA6VvEvNpW/MHPOaym0FBcYUcuSeZU=; b=IlLX1TYN3xV9vVXmklU+Vdn0/mk/OBIEpHMLjq81Wn3YMKTmaixquqWOLD5tWK3qLVODFG XqBBIqVCNQPKQPf0hA3yJzdQLghvb/lYUNVxdHTF3xJ0cgojH0oJ0VYvaVl1Gqs6A5dDgw A2pw7IlXlgF4H5ZSflJyg6fxLUkrFrQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-xxYtuhuUPNuX4H3pPlTEng-1; Thu, 09 Jun 2022 13:38:43 -0400 X-MC-Unique: xxYtuhuUPNuX4H3pPlTEng-1 Received: by mail-wm1-f72.google.com with SMTP id m22-20020a7bcb96000000b0039c4f6ade4dso3855300wmi.8 for ; Thu, 09 Jun 2022 10:38:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=k6TtggULp7/GiOA6VvEvNpW/MHPOaym0FBcYUcuSeZU=; b=art/3x8y0mMwIULZ8q/KknDE5Q8f0LDkRyOvNVdBbb9IsxrbCfxkEEsaAkBDw1muRv LGmFZkL+DLncVueiloxWTwatuc9RV0//sSFk9FjrOOziHugoOCFUSS2+UJTF+n6ZO/HO Omw3N8rP73NqYag1ZKUdEijBxr9jKrAGBENssAmWlQvyyEPFVKqg8D+f15QY683VuKLE REjTE8XZwvfoip4LnHWjDwJORYRoFbCFf8fN+zd/IOs/EzHARtJM2Umsng684CikVUcO zaReldcEOnyg8hXx2XJ2qHTFo4g/wAPVd1fqD8dF+FK4D/k6jrzDDeIk3iNrzgTnZ4l+ pOlw== X-Gm-Message-State: AOAM533jmVy7bukgBWLa9HW7uxIiamCcBNYV/aZmcTCjTx6szbP4w10e jFWTrV2AQN/wdwrWo6SDfCWGLlIyvFikmC5oVr//1HixkPsu2dV74hDlRG8z80g88qoQFaxDe3U 7GzWPrhT4h/vXTH9vkNdaCqs= X-Received: by 2002:a5d:6283:0:b0:213:b939:826d with SMTP id k3-20020a5d6283000000b00213b939826dmr35332060wru.543.1654796322083; Thu, 09 Jun 2022 10:38:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycbjbAoqYi/Z38MH7gotfLoia/Ifcg797dUpu4eGDAE74k+ABciK+rkA2pggXKQtSvmd1fZw== X-Received: by 2002:a5d:6283:0:b0:213:b939:826d with SMTP id k3-20020a5d6283000000b00213b939826dmr35332021wru.543.1654796321841; Thu, 09 Jun 2022 10:38:41 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id z2-20020adff1c2000000b0020c5253d8dcsm23897952wro.40.2022.06.09.10.38.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 10:38:41 -0700 (PDT) Message-ID: <0bdbec1f-196b-b82e-9d64-06029e250983@redhat.com> Date: Thu, 9 Jun 2022 19:38:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Mark olpc_dcon BROKEN [Was: [PATCH v6 5/5] fbdev: Make registered_fb[] private to fbmem.c] Content-Language: en-US To: Sam Ravnborg , Jerry Lin , Greg Kroah-Hartman Cc: Thomas Zimmermann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laszlo Ersek , Alex Williamson , Gerd Hoffmann , kvm@vger.kernel.org, Daniel Vetter , kernel test robot , Jens Frederich , Jon Nettleton , linux-staging@lists.linux.dev, Daniel Vetter , Daniel Vetter , Helge Deller , Matthew Wilcox , Tetsuo Handa , Zhen Lei , Alex Deucher , Xiyu Yang , linux-fbdev@vger.kernel.org, Zheyu Ma , Guenter Roeck References: <20220607182338.344270-1-javierm@redhat.com> <20220607182338.344270-6-javierm@redhat.com> <3ebac271-1276-8132-6175-ca95a26cfcbb@suse.de> <69d8ad0e-efc6-f37d-9aa7-d06f8de16a6a@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hello Sam, On 6/9/22 19:23, Sam Ravnborg wrote: [snip] > > To repeat myself from irc. > olpc_dcon is a staging driver and we should avoid inventing anything in > core code for to make staging drivers works. > Geert suggested EXPORT_SYMPBOL_NS_GPL() that could work and narrow it > down to olpc_dcon. > The better approach is to mark said driver BROKEN and then someone can > fix it it there is anyone who cares. > Last commit to olpc_dcon was in 2019: e40219d5e4b2177bfd4d885e7b64e3b236af40ac > and maybe Jerry Lin cares enough to fix it. > > Added Jerry and Greg to the mail. > > Sam > That does sound like the best approach indeed. And if the driver is kept BROKEN for a few releases then it can just remove it from the kernel. If someone still uses/cares about the driver, they can fix it as you said, and it could even be ported to DRM if is something that's still useful. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat