* [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS
@ 2024-10-18 15:12 Arnd Bergmann
2024-10-18 15:21 ` Helge Deller
2024-10-21 7:19 ` Thomas Zimmermann
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-10-18 15:12 UTC (permalink / raw)
To: Helge Deller, Javier Martinez Canillas, Thomas Zimmermann
Cc: Arnd Bergmann, linux-fbdev, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The fb_io_mmap() function is used in the file operations but
not enabled in all configurations unless FB_IOMEM_FOPS gets
selected:
ld.lld-20: error: undefined symbol: fb_io_mmap
>>> referenced by wm8505fb.c
>>> drivers/video/fbdev/wm8505fb.o:(wm8505fb_ops) in archive vmlinux.a
Fixes: 11754a504608 ("fbdev/wm8505fb: Initialize fb_ops to fbdev I/O-memory helpers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 9957dde4a3f6..961d7f5bbbc2 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1388,6 +1388,7 @@ config FB_VT8500
config FB_WM8505
bool "Wondermedia WM8xxx-series frame buffer support"
depends on (FB = y) && HAS_IOMEM && (ARCH_VT8500 || COMPILE_TEST)
+ select FB_IOMEM_FOPS
select FB_SYS_FILLRECT if (!FB_WMT_GE_ROPS)
select FB_SYS_COPYAREA if (!FB_WMT_GE_ROPS)
select FB_SYS_IMAGEBLIT
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS
2024-10-18 15:12 [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS Arnd Bergmann
@ 2024-10-18 15:21 ` Helge Deller
2024-10-21 7:19 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Helge Deller @ 2024-10-18 15:21 UTC (permalink / raw)
To: Arnd Bergmann, Javier Martinez Canillas, Thomas Zimmermann
Cc: Arnd Bergmann, linux-fbdev, dri-devel, linux-kernel
On 10/18/24 17:12, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The fb_io_mmap() function is used in the file operations but
> not enabled in all configurations unless FB_IOMEM_FOPS gets
> selected:
>
> ld.lld-20: error: undefined symbol: fb_io_mmap
>>>> referenced by wm8505fb.c
>>>> drivers/video/fbdev/wm8505fb.o:(wm8505fb_ops) in archive vmlinux.a
>
> Fixes: 11754a504608 ("fbdev/wm8505fb: Initialize fb_ops to fbdev I/O-memory helpers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS
2024-10-18 15:12 [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS Arnd Bergmann
2024-10-18 15:21 ` Helge Deller
@ 2024-10-21 7:19 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2024-10-21 7:19 UTC (permalink / raw)
To: Arnd Bergmann, Helge Deller, Javier Martinez Canillas
Cc: Arnd Bergmann, linux-fbdev, dri-devel, linux-kernel
Am 18.10.24 um 17:12 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The fb_io_mmap() function is used in the file operations but
> not enabled in all configurations unless FB_IOMEM_FOPS gets
> selected:
>
> ld.lld-20: error: undefined symbol: fb_io_mmap
>>>> referenced by wm8505fb.c
>>>> drivers/video/fbdev/wm8505fb.o:(wm8505fb_ops) in archive vmlinux.a
> Fixes: 11754a504608 ("fbdev/wm8505fb: Initialize fb_ops to fbdev I/O-memory helpers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 9957dde4a3f6..961d7f5bbbc2 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1388,6 +1388,7 @@ config FB_VT8500
> config FB_WM8505
> bool "Wondermedia WM8xxx-series frame buffer support"
> depends on (FB = y) && HAS_IOMEM && (ARCH_VT8500 || COMPILE_TEST)
> + select FB_IOMEM_FOPS
> select FB_SYS_FILLRECT if (!FB_WMT_GE_ROPS)
> select FB_SYS_COPYAREA if (!FB_WMT_GE_ROPS)
> select FB_SYS_IMAGEBLIT
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-21 7:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 15:12 [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS Arnd Bergmann
2024-10-18 15:21 ` Helge Deller
2024-10-21 7:19 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).