From: Randy Dunlap <rdunlap@infradead.org>
To: Colin Ian King <colin.i.king@gmail.com>,
Helge Deller <deller@gmx.de>, Nikita Romanyuk <ufh8945@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: video: logo: use %u format specifier for unsigned int values
Date: Tue, 19 Dec 2023 13:51:30 -0800 [thread overview]
Message-ID: <0f3bb667-a458-432e-b6bc-1ae8c4277b8e@infradead.org> (raw)
In-Reply-To: <20231219151436.368696-1-colin.i.king@gmail.com>
On 12/19/23 07:14, Colin Ian King wrote:
> Currently the %d format specifier is being used for unsigned int values.
> Fix this by using the correct %u format specifier. Cleans up cppcheck
> warnings:
>
> warning: %d in format string (no. 1) requires 'int' but the argument
> type is 'unsigned int'. [invalidPrintfArgType_sint]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/video/logo/pnmtologo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/logo/pnmtologo.c b/drivers/video/logo/pnmtologo.c
> index ada5ef6e51b7..2434a25afb64 100644
> --- a/drivers/video/logo/pnmtologo.c
> +++ b/drivers/video/logo/pnmtologo.c
> @@ -249,10 +249,10 @@ static void write_footer(void)
> fputs("\n};\n\n", out);
> fprintf(out, "const struct linux_logo %s __initconst = {\n", logoname);
> fprintf(out, "\t.type\t\t= %s,\n", logo_types[logo_type]);
> - fprintf(out, "\t.width\t\t= %d,\n", logo_width);
> - fprintf(out, "\t.height\t\t= %d,\n", logo_height);
> + fprintf(out, "\t.width\t\t= %u,\n", logo_width);
> + fprintf(out, "\t.height\t\t= %u,\n", logo_height);
> if (logo_type == LINUX_LOGO_CLUT224) {
> - fprintf(out, "\t.clutsize\t= %d,\n", logo_clutsize);
> + fprintf(out, "\t.clutsize\t= %u,\n", logo_clutsize);
> fprintf(out, "\t.clut\t\t= %s_clut,\n", logoname);
> }
> fprintf(out, "\t.data\t\t= %s_data\n", logoname);
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
prev parent reply other threads:[~2023-12-19 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 15:14 [PATCH] drivers: video: logo: use %u format specifier for unsigned int values Colin Ian King
2023-12-19 21:51 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f3bb667-a458-432e-b6bc-1ae8c4277b8e@infradead.org \
--to=rdunlap@infradead.org \
--cc=colin.i.king@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ufh8945@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).