From: Helge Deller <deller@gmx.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Javier Martinez Canillas <javierm@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>, Zheng Wang <zyytlz.wz@163.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] fbdev/imsttfb: fix double free in probe()
Date: Sun, 5 Nov 2023 19:22:07 +0100 [thread overview]
Message-ID: <0f93f782-08bf-4a2e-b370-806602fe1eee@gmx.de> (raw)
In-Reply-To: <014c0272-0d53-4625-8517-e8b4aa68f4dd@moroto.mountain>
On 10/27/23 14:04, Dan Carpenter wrote:
> The init_imstt() function calls framebuffer_release() on error and then
> the probe() function calls it again. It should only be done in probe.
>
> Fixes: 518ecb6a209f ("fbdev: imsttfb: Fix error path of imsttfb_probe()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Both patches applied.
Thanks!
Helge
prev parent reply other threads:[~2023-11-05 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 12:04 [PATCH 1/2] fbdev/imsttfb: fix double free in probe() Dan Carpenter
2023-10-27 12:05 ` [PATCH 2/2] fbdev/imsttfb: fix a resource leak in probe Dan Carpenter
2023-11-05 18:22 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f93f782-08bf-4a2e-b370-806602fe1eee@gmx.de \
--to=deller@gmx.de \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox