Re: [PATCH] inivisible cursor on vesafb

[Antonino Daplas <adaplas@pol.net>]

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

On Mon, 2002-08-19 at 07:05, Petr Vandrovec wrote:
> Hi Linus,
> 
> Since vesafb was converted to the (strange) cfb* interface, it uses random
> colors for the cursor, making cursor invisible when console uses black foreground
> (f.e. Midnight Commander does that). Problem is common to all fbdevs which
> use fbcon-accel interface.
> 
> This change tries to restore old behavior which existed before cfb* came in.
> Unfortunately due to region.color semantic it is not possible to completely
> restore previous behavior - 
> + for truecolor cfbfillrect always consults current palette, so we do not 
>   have "always invert" constant available, and so we do inversion with palette
>   color 15 (it is light white, ~0, by default)
> + for directcolor it assumes that display has at least 4 bits per color.
> + for pseudocolor it works as old code worked.
> 

I think it has been agreed that all color entries in fbcon-accel should
always be an index to the pseudopalette regardless of the visuals.  So a
more consistent change is to have cfbfillrect look up the color from the
pseudopalette assuming that the driver correctly loaded the value to the
pseudopalette.



[-- Attachment #2: directcolor.diff --]
[-- Type: text/plain, Size: 470 bytes --]

--- cfbfillrect.c-orig	Mon Aug 19 00:46:03 2002
+++ cfbfillrect.c	Mon Aug 19 00:48:31 2002
@@ -52,7 +52,8 @@
 	start_index = ((unsigned long) dst1 & (bpl - 1));
 	end_index = ((unsigned long) (dst1 + n) & (bpl - 1));
 
-	if (p->fix.visual == FB_VISUAL_TRUECOLOR)
+	if (p->fix.visual == FB_VISUAL_TRUECOLOR || 
+	    p->fix.visual == FB_VISUAL_DIRECTCOLOR  )
 		fg = fgcolor = ((u32 *) (p->pseudo_palette))[rect->color];
 	else
 		fg = fgcolor = rect->color;