From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2002-Q4@gmx.net>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: Linux 2.4.20-rc1
Date: 08 Nov 2002 17:34:18 +0100 [thread overview]
Message-ID: <1036773258.8907.90.camel@zion> (raw)
In-Reply-To: <3DCBAC99.7010909@gmx.net>
On Fri, 2002-11-08 at 13:22, Carl-Daniel Hailfinger wrote:
> I managed to trim down the offending patch further. Reverting the new
> attached patch is enough to fix my problem. Can someone of the framebuffer
> experts please comment on this one?
Ok, I'm the one to blame for that patch.
It was intended to fix some problems where the console subsystem
would call fbcon_blank after the fbdev HW was put to suspend, thus
crashing the system.
This should really be fixed in the low level fb drivers to ignore
blanking when they are asleep though. This is a kind of hack as 2.4
lacks a proper model for ordering power management requests
Marcelo, feel free to delete those 4 lines (but not the whole patch),
just the 4 lines in fbcon_blank, I'll make sure the various drivers
are made safe.
Ben.
prev parent reply other threads:[~2002-11-08 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44L.0211061033410.27268-100000@freak.distro.conectiva>
2002-11-07 18:21 ` Linux 2.4.20-rc1 Carl-Daniel Hailfinger
2002-11-08 12:22 ` Carl-Daniel Hailfinger
2002-11-08 16:34 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1036773258.8907.90.camel@zion \
--to=benh@kernel.crashing.org \
--cc=c-d.hailfinger.kernel.2002-Q4@gmx.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).