From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antonino Daplas Subject: Re: new logo drawing code Date: 03 Jan 2003 18:33:06 +0800 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1041589394.1014.7.camel@localhost.localdomain> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from willow.compass.com.ph ([202.70.96.38]) by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 18UPLM-0003nH-00 for ; Fri, 03 Jan 2003 02:46:24 -0800 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: James Simmons , Linux Frame Buffer Device Development On Mon, 2002-12-30 at 04:07, Geert Uytterhoeven wrote: > > Did anyone actually test fbcon_set_logo() on monochrome hardware? > > I admit I haven't tried it myself yet (still fighting with amifb), but this > looks more reasonable: > - Use index i*8+j instead of i*2 This part is fixed in linux-2.5.54. > - Replace conditionals by straight code without branches (bit 7 of needs_logo > is either 0 (normal) or 1 (reverse), and perhaps we should kill the default > case?). This is cleaner, I believe. Tony ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf