From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antonino Daplas Subject: Re: clipping Date: 03 Jan 2003 18:36:08 +0800 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1041589565.1014.10.camel@localhost.localdomain> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from willow.compass.com.ph ([202.70.96.38]) by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 18UQ6U-0001ei-00 for ; Fri, 03 Jan 2003 03:35:06 -0800 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: Linux Frame Buffer Device Development On Mon, 2002-12-30 at 05:21, Geert Uytterhoeven wrote: > > cfb_imageblit() takes care of clipping, but forgets to update fb_image.data if > fb_image.d[xy] was changed. > > BTW, do we really need clipping in fb_ops.fb_{fillrect,copyarea,imageblit}()? Personally, I don't think we need clipping. I tried removing it before (circa linux-2.5.30+), but the console segfaults whenever I decrease var->yres_virtual. I haven't tried this again with the newest framebuffer framework though. Tony ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf