From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antonino Daplas Subject: Re: Re: [PATCH]: image.depth fix to accomodate monochrome cards Date: 11 Jan 2003 21:47:18 +0800 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1042292794.1389.91.camel@localhost.localdomain> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from willow.compass.com.ph ([202.70.96.38]) by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 18XM8j-0007DF-00 for ; Sat, 11 Jan 2003 05:57:33 -0800 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: James Simmons , Linux Fbdev development list On Sat, 2003-01-11 at 21:24, Geert Uytterhoeven wrote: > > > > Do you think this will work? The only problem I can think of is a color > > expansion request where both bg and fg is 0. > > And that can happen, try [31m[41m to set both to red. > > > Or to totally eliminate the above possibility, add an extra field in > > struct fb_image to denote color expansion vs logo drawing. Again, only > > mono cards will need to do this test. > > Ugh, why invent a new field if we can use an existing field? depth == 0 is > invalid for image blitting anyway. > No argument here. Tony ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com