From: Antonino Daplas <adaplas@pol.net>
To: Jak <rfjak@eircom.net>
Cc: James Simmons <jsimmons@infradead.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: rivafb "Badness" using fbdev.diff.gz and 2.5.5[45]
Date: 21 Jan 2003 08:08:06 +0800 [thread overview]
Message-ID: <1043106974.997.11.camel@localhost.localdomain> (raw)
In-Reply-To: <200301201909.10951.rfjak@eircom.net>
On Tue, 2003-01-21 at 03:09, Jak wrote:
>
> > int __init rivafb_init(void)
> > {
> > - int err;
> > - err = pci_module_init(&rivafb_driver);
> > - if (err)
> > - return err;
> > - pci_register_driver(&rivafb_driver);
> > - return 0;
> > + return pci_module_init(&rivafb_driver);
> > }
> >
Hmm, come to think of it, pci_module_init() is old-style. Using
return (pci_register_driver(&rivafb_driver) > 0) ? 0 : -ENODEV;
instead is better and will allow the rivafb driver to appear in sysfs.
Anyway, pci_module_init() should not be called since
pci_register_driver() already does that for you. That's what causing
the "Badness" in kobject.
Tony
-------------------------------------------------------
This SF.NET email is sponsored by: FREE SSL Guide from Thawte
are you planning your Web Server Security? Click here to get a FREE
Thawte SSL guide and find the answers to all your SSL security issues.
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
next prev parent reply other threads:[~2003-01-21 0:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 13:30 rivafb "Badness" using fbdev.diff.gz and 2.5.5[45] Jak
2003-01-15 0:43 ` James Simmons
2003-01-18 20:28 ` Jak
2003-01-19 15:40 ` Antonino Daplas
2003-01-20 19:09 ` Jak
2003-01-20 22:44 ` Antonino Daplas
2003-01-21 10:29 ` Geert Uytterhoeven
2003-01-21 11:31 ` Antonino Daplas
2003-01-24 22:53 ` James Simmons
2003-01-25 9:00 ` Geert Uytterhoeven
2003-01-30 23:00 ` Antonino Daplas
2003-02-12 20:13 ` James Simmons
2003-01-21 0:08 ` Antonino Daplas [this message]
2003-01-24 20:14 ` James Simmons
2003-01-30 23:01 ` Antonino Daplas
2003-02-12 20:15 ` James Simmons
2003-02-12 23:37 ` Antonino Daplas
2003-01-24 19:09 ` James Simmons
-- strict thread matches above, loose matches on Subject: below --
2003-01-19 11:29 Fredrik Noring
2003-01-19 15:41 ` Antonino Daplas
2003-01-19 16:42 ` Fredrik Noring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1043106974.997.11.camel@localhost.localdomain \
--to=adaplas@pol.net \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=rfjak@eircom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).