linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antonino Daplas <adaplas@pol.net>
To: Antonino Daplas <adaplas@pol.net>
Cc: James Simmons <jsimmons@infradead.org>,
	Linux Fbdev development list
	<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] Tile Blitting
Date: 23 Feb 2003 19:07:57 +0800	[thread overview]
Message-ID: <1045998239.1188.4.camel@localhost.localdomain> (raw)
In-Reply-To: <1045986190.1189.2.camel@localhost.localdomain>

On Sun, 2003-02-23 at 15:43, Antonino Daplas wrote:
> On Sun, 2003-02-23 at 12:42, Antonino Daplas wrote:
> 
> > Here's an updated Tile Blitting patch.  The feature is selectable via
> > kernel configuration (under Advanced Low Level Driver Features). 
> > Currently, it detects the presence of info->tileops but bit setting
> > info->caps should be better.
> 
> Stupid me :-(, the patch does not work properly.  Try this one instead.
> 

The optimization logic is flawed :-(  Please apply this patch also.

Tony

diff -Naur linux-2.5.61-fbdev/drivers/video/console/fbcon_accelops.c linux-2.5.61/drivers/video/console/fbcon_accelops.c
--- linux-2.5.61-fbdev/drivers/video/console/fbcon_accelops.c	2003-02-23 18:47:53.000000000 +0800
+++ linux-2.5.61/drivers/video/console/fbcon_accelops.c	2003-02-23 18:52:23.000000000 +0800
@@ -113,13 +113,16 @@
 					src++;
 				}
 				dst[idx] &= mask;
-				dst[idx] |= *src++ >> shift_low;
+				dst[idx] |= *src >> shift_low;
+ 				if (shift_high < mod)
+					dst[idx+1] = *src << shift_high;
+				src++;
 				dst += pitch;
 			}
 			shift_low += mod;
+			dst0 += (shift_low >= 8) ? width : width - 1;
 			shift_low &= 7;
 			shift_high = 8 - shift_low;
-			dst0 += (shift_low) ? width - 1 : width;
 		}
 		
 		info->fbops->fb_imageblit(info, image);



-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
www.slickedit.com/sourceforge

  reply	other threads:[~2003-02-23 11:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-23  4:42 [PATCH] Tile Blitting Antonino Daplas
2003-02-23  7:43 ` Antonino Daplas
2003-02-23 11:07   ` Antonino Daplas [this message]
2003-02-26 20:11     ` James Simmons
2003-02-27  0:35       ` Antonino Daplas
2003-02-27  1:18         ` James Simmons
2003-02-27 14:15           ` Antonino Daplas
2003-02-27 18:25             ` Michel Dänzer
2003-02-27 19:48               ` James Simmons
2003-03-02 12:14                 ` Geert Uytterhoeven
2003-03-03 21:32                   ` Antonino Daplas
2003-02-27 21:47               ` Antonino Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1045998239.1188.4.camel@localhost.localdomain \
    --to=adaplas@pol.net \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).