Re: Some questions

[Antonino Daplas <adaplas@pol.net>]

On Thu, 2003-03-06 at 00:17, Thomas Winischhofer wrote:
> Antonino Daplas wrote:
> >> > Strange.  If you boot at 800x600, the console will compute that as
> >> > 100x37.  On fbcon_resize, it will request 800x592 but because the
> >> > difference is only 8, fb_set_var should be skipped, so no mode change
> >> > should happen throughout.
> >>
> >>But it definitely does. I can see this on my LCD (which goes dark during 
> >>mode changes) and, of course, the log.
> 
> Just check this with the newest versions from fbdev at bk. In my code 
> (which is, as I said in the beginning, the stock 2.5.63 kernel), 
> fbcon_resize does NO check whatsoever. It stupidly calls set_var().

Of course.  My tree is so modified that I forgot that Jame's latest
patch was not yet applied to the main tree :-)
> 
> I think that might be one reason for what I see :)

http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz

Note that there is still a bug in fbcon_resize().

1.  in fbcon_resize(), p->vrows must be updated unconditionally

2.  fbcon_resize() in fbcon_switch() must be moved higher up the code,
preferably before the scroll_phys_max calculation.

Tony



-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com